[VEN-3018]: configure RiskStewardReceiver and MarketCapsRiskSteward #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreyar
force-pushed
the
configure-risk-steward
branch
from
df3efce to
a3ed6e9
Compare
chechu
changed the title
coreyar
force-pushed
the
configure-risk-steward
branch
from
a3ed6e9 to
9cfc49c
Compare
coreyar
force-pushed
the
configure-risk-steward
branch
from
5fcb751 to
9f693c5
Compare
chechu
reviewed
Jan 21, 2025
vips/vip-xxx/bsctestnet.ts
Outdated
Comment on lines
101
to
110
| ...IL_COMPTROLLERS.map((comptroller) => ({ | ||
| target: ACM, | ||
| signature: "giveCallPermission(address,string,address)", | ||
| params: [comptroller, "setMarketSupplyCaps(address[],uint256[])", MARKET_CAPS_RISK_STEWARD], | ||
| })), | ||
| ...IL_COMPTROLLERS.map((comptroller) => ({ | ||
| target: ACM, | ||
| signature: "giveCallPermission(address,string,address)", | ||
| params: [comptroller, "setMarketBorrowCaps(address[],uint256[])", MARKET_CAPS_RISK_STEWARD], | ||
| })), |
There was a problem hiding this comment.
I think it would make sense to use the wildcard 0x0 in this case, allowing the risk steward contracts to invoke the mentioned functions on any contract. This way, we won't have to update the permissions if a new pool is added in the future
chechu
reviewed
Jan 21, 2025
vips/vip-xxx/bsctestnet.ts
Outdated
| export const LIQUID_STAKING_ETH_COMPTROLLER = "0xC7859B809Ed5A2e98659ab5427D5B69e706aE26b"; | ||
| export const MEME_COMPTROLLER = "0x92e8E3C202093A495e98C10f9fcaa5Abe288F74A"; | ||
| export const ACM = "0x45f8a08F534f34A97187626E05d4b6648Eeaa9AA"; | ||
| export const RISK_STEWARD_RECEIVER = "0x34e4505f92C8499B07eeb7Aa72404A490D152Ab3"; |
There was a problem hiding this comment.
I don't see this contract deployed at VenusProtocol/governance-contracts#115
There was a problem hiding this comment.
I haven't pushed the deployments. (Updated and pushing)
chechu
reviewed
Jan 21, 2025
vips/vip-xxx/bsctestnet.ts
Outdated
Comment on lines
61
to
80
| { | ||
| target: ACM, | ||
| signature: "giveCallPermission(address,string,address)", | ||
| params: [RISK_STEWARD_RECEIVER, "setRiskParameterConfig(string,address,uint256)", NORMAL_TIMELOCK], | ||
| }, | ||
| { | ||
| target: ACM, | ||
| signature: "giveCallPermission(address,string,address)", | ||
| params: [RISK_STEWARD_RECEIVER, "toggleConfigActive(string)", NORMAL_TIMELOCK], | ||
| }, | ||
| { | ||
| target: ACM, | ||
| signature: "giveCallPermission(address,string,address)", | ||
| params: [RISK_STEWARD_RECEIVER, "pause()", NORMAL_TIMELOCK], | ||
| }, | ||
| { | ||
| target: ACM, | ||
| signature: "giveCallPermission(address,string,address)", | ||
| params: [RISK_STEWARD_RECEIVER, "unpause()", NORMAL_TIMELOCK], | ||
| }, |
There was a problem hiding this comment.
I think Fast-track and Critical timelocks should also be authorized to call these functions
chechu
reviewed
Jan 21, 2025
Comment on lines
+86
to
+90
| { | ||
| target: ACM, | ||
| signature: "giveCallPermission(address,string,address)", | ||
| params: [MARKET_CAPS_RISK_STEWARD, "setMaxIncreaseBps(uint256)", NORMAL_TIMELOCK], | ||
| }, |
There was a problem hiding this comment.
I would also authorize Fast-track and Critical timelocks
…e for calling IL pools
coreyar
force-pushed
the
configure-risk-steward
branch
3 times, most recently
from
a4b87c8 to
9c63bb2
Compare
coreyar
force-pushed
the
configure-risk-steward
branch
from
9c63bb2 to
55928da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves VEN