Refactor to a constant; update unit test

Versent · Oct 31, 2023 · bec46e2 · bec46e2
1 parent 98624e6
commit bec46e2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/pkg/provider/browser/browser.go b/pkg/provider/browser/browser.go
@@ -13,6 +13,8 @@ import (
 
 var logger = logrus.WithField("provider", "browser")
 
+var TimeoutPageWaitForRequest = newPageWaitForRequestOptions(300000)
+
 // Client client for browser based Identity Provider
 type Client struct {
 	Headless bool
@@ -94,8 +96,7 @@ var getSAMLResponse = func(page playwright.Page, loginDetails *creds.LoginDetail
 	}
 
 	logger.Info("waiting ...")
-	var timeout float64 = 300000
-	r, _ := page.WaitForRequest(signin_re, playwright.PageWaitForRequestOptions{Timeout: &timeout})
+	r, _ := page.WaitForRequest(signin_re, TimeoutPageWaitForRequest)
 	data, err := r.PostData()
 	if err != nil {
 		return "", err
@@ -124,3 +125,7 @@ func (cl *Client) Validate(loginDetails *creds.LoginDetails) error {
 
 	return nil
 }
+
+func newPageWaitForRequestOptions(timeout float64) playwright.PageWaitForRequestOptions {
+	return playwright.PageWaitForRequestOptions{Timeout: &timeout}
+}
diff --git a/pkg/provider/browser/browser_test.go b/pkg/provider/browser/browser_test.go
@@ -107,7 +107,7 @@ func TestGetSAMLResponse(t *testing.T) {
 	regex, err := signinRegex()
 	assert.Nil(t, err)
 	page.Mock.On("Goto", url).Return(resp, nil)
-	page.Mock.On("WaitForRequest", regex).Return(req)
+	page.Mock.On("WaitForRequest", regex, TimeoutPageWaitForRequest).Return(req)
 	req.Mock.On("PostData").Return(params.Encode(), nil)
 	// loginDetails := &creds.LoginDetails{
 	//	URL: url,