New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAJOR] Replay/Rework Overall bazel Build #5

Closed

8 tasks done

ghost opened this issue Mar 14, 2023 · 1 comment

ghost commented Mar 14, 2023 •

edited by ghost

Loading

This issue lists several task that attempt to fix

Black stripes in denoised image #1

Requirements and Feasibility Analysis "Bazelizing Open Image Denoise" #3
(following list ordered by "highest estimated possibility of root-cause")
Use the exact same "mkl_dnn" version as cmake #7
- Why is 0001-Bazel-support.patch applied? #9
Do not use in-sources ispc, use external ispc #10
Use the exact same "weights" as cmake #8
Use the recommended toolchain (clang) #6
(convenience stuff, but essentially a must have)
Test/Reproducer not working #4
Provide Reference Test Reproducer #11

ghost changed the title ~~Rework Overall Build~~ Replay/Rework Overall bazel Build

ghost changed the title ~~Replay/Rework Overall bazel Build~~ [MAJOR] Replay/Rework Overall bazel Build

ghost mentioned this issue

Black stripes in denoised image #1

Closed

Owner

Vertexwahn commented Mar 16, 2023

#1 was solved

Vertexwahn closed this as completed

This was referenced Mar 16, 2023

Provide a Compatible build #13

Open

Do not use in-sources ispc, use external ispc #10

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment