Skip to content

Commit

Permalink
Cleaned build script by using mc_version for comparisons
Browse files Browse the repository at this point in the history
  • Loading branch information
FlorianMichael committed Feb 3, 2024
1 parent bc32c47 commit 060d4b5
Show file tree
Hide file tree
Showing 8 changed files with 11 additions and 20 deletions.
9 changes: 0 additions & 9 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,6 @@ jobs:
java-version: 8
distribution: 'temurin'
check-latest: true
- name: Cache Dependencies
uses: actions/cache@v3
with:
path: |
~/.gradle/caches
~/.gradle/wrapper
key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*', '**/gradle-wrapper.properties') }}
restore-keys: |
${{ runner.os }}-gradle-
- name: Build with Gradle
run: ./gradlew shadowJar
- name: Upload Build Artifacts
Expand Down
16 changes: 11 additions & 5 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,9 @@ subprojects {
version = maven_version + "-" + project.mc_version
group = maven_group

// Used to execute code only for specific submodules
def versionId = Integer.parseInt(project.mc_version.replace(".", ""))

compileJava.options.encoding = "UTF-8"

minecraft {
Expand Down Expand Up @@ -107,7 +110,8 @@ subprojects {
}

dependencies {
if ((project.property("sub_module_increment") as Integer) >= 2) {
if (versionId >= 1171) {
// Minecraft 1.17+ already includes slf4j, so we don't need to include it
compileOnly "org.slf4j:slf4j-api:${slf4j_version}"
} else {
library "org.slf4j:slf4j-api:${slf4j_version}"
Expand Down Expand Up @@ -143,7 +147,7 @@ subprojects {
}

java {
if ((project.property("sub_module_increment") as Integer) >= 2) {
if (versionId >= 1171) {
// Minecraft 1.17+ required Java 16/17 to compile
toolchain.languageVersion = JavaLanguageVersion.of(17)
}
Expand All @@ -158,12 +162,14 @@ subprojects {
exclude("META-INF/maven/**")
exclude("META-INF/versions/**")

if ((project.property("sub_module_increment") as Integer) >= 1) {
if (versionId >= 1132) {
// We don't need to package mixins into Forge 1.13+ jars, since Forge already has it
exclude("org/spongepowered/**")
}
if (versionId >= 1165) {
// Get rid of the services folder, since Forge 1.16+ would conflict with some of the ForgeDev Environment's services
// And since we don't need them for Mixins anyway, we can just exclude them from the shadowJar
exclude("META-INF/services/**")
// We don't need to package mixins into Forge 1.13+ jars, since Forge already has it
exclude("org/spongepowered/**")
}
}

Expand Down
1 change: 0 additions & 1 deletion viaforge-mc112/gradle.properties
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
maven_name=viaforge-mc112
mc_version=1.12.2
sub_module_increment=0
1 change: 0 additions & 1 deletion viaforge-mc116/gradle.properties
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
maven_name=viaforge-mc116
mc_version=1.16.5
sub_module_increment=1
1 change: 0 additions & 1 deletion viaforge-mc117/gradle.properties
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
maven_name=viaforge-mc117
mc_version=1.17.1
sub_module_increment=2
1 change: 0 additions & 1 deletion viaforge-mc118/gradle.properties
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
maven_name=viaforge-mc118
mc_version=1.18.2
sub_module_increment=3
1 change: 0 additions & 1 deletion viaforge-mc119/gradle.properties
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
maven_name=viaforge-mc119
mc_version=1.19.4
sub_module_increment=4
1 change: 0 additions & 1 deletion viaforge-mc120/gradle.properties
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
maven_name=viaforge-mc120
mc_version=1.20.4
sub_module_increment=5

0 comments on commit 060d4b5

Please sign in to comment.