Replaced jank GUI by ViaMCP's slider #69
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops seems like my previous PR is in there too, it's basically useless now tho (changes GuiProtocolSelector which is unused), I can open another PR if you want to keep things a bit cleaner |
|
No thanks, I want ViaForge to keep the GUI, the code of the slider is just way too bad, I might make a better slider sometime, because you could then also add. |
|
I agree the slider's code isn't the best, but is there really a need to keep only the horrendous GUI instead ? |
|
I will look into a "good" implementation/solution for both slider and slot gui |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title again, 95% of the work was already done, just tied up things a bit and ported to Forge
Didn't delete GuiProtocolSelector even tho it's unused as ViaMCP doesn't seem to have deleted it either?