Add support for taxes in the generic parser (#105)

GhostfolioSidekick.UnitTests/FileImporter/Generic/GenericParserTests.cs

@@ -128,5 +128,36 @@ public async Task ConvertActivitiesForAccount_SingleFee_Converted()
 				)
 			});
 		}
+
+		[Fact]
+		public async Task ConvertActivitiesForAccount_SingleDividend_Converted()
+		{
+			// Arrange
+			var parser = new GenericParser(api.Object);
+			var fixture = new Fixture();
+
+			var asset = fixture.Build<Model.SymbolProfile>().With(x => x.Currency, DefaultCurrency.USD).Create();
+			var account = fixture.Build<Account>().With(x => x.Balance, Balance.Empty(DefaultCurrency.USD)).Create();
+
+			api.Setup(x => x.GetAccountByName(account.Name)).ReturnsAsync(account);
+			api.Setup(x => x.FindSymbolByIdentifier("US2546871060", It.IsAny<Currency>(), It.IsAny<AssetClass[]>(), It.IsAny<AssetSubClass[]>(), true, false)).ReturnsAsync(asset);
+
+			// Act
+			account = await parser.ConvertActivitiesForAccount(account.Name, new[] { "./FileImporter/TestFiles/Generic/CashTransactions/single_dividend.csv" });
+
+			// Assert
+			account.Balance.Current(DummyPriceConverter.Instance).Should().BeEquivalentTo(new Money(DefaultCurrency.USD, 0.067669M, new DateTime(2023, 08, 8, 0, 0, 0, DateTimeKind.Utc)));
+			account.Activities.Should().BeEquivalentTo(new[] { new Activity(
+				ActivityType.Dividend,
+				asset,
+				new DateTime(2023,08,8, 0,0,0, DateTimeKind.Utc),
+				0.3247M,
+				new Money(DefaultCurrency.EUR, 0.2084046812442254388666461349M, new DateTime(2023,08,8, 0,0,0, DateTimeKind.Utc)),
+				new[] { new Money(DefaultCurrency.EUR, 0, new DateTime(2023,08,8, 0,0,0, DateTimeKind.Utc)) },
+				"Transaction Reference: [Dividend_US2546871060_2023-08-08_0.3247_EUR_0] (Details: asset US2546871060)",
+				"Dividend_US2546871060_2023-08-08_0.3247_EUR_0"
+				)
+			});
+		}
 	}
 }

GhostfolioSidekick.UnitTests/FileImporter/TestFiles/Generic/CashTransactions/single_dividend.csv

@@ -0,0 +1,2 @@
+ActivityType,Symbol,Date,Currency,Quantity,UnitPrice,Fee,Tax,Description,Id
+Dividend,US2546871060,2023-08-8,EUR,0.3247,0.27,0,0.02,,

GhostfolioSidekick.UnitTests/GhostfolioSidekick.UnitTests.csproj

@@ -91,6 +91,9 @@
     <None Update="FileImporter\TestFiles\DeGiro\PT\SellOrders\single_sell_euro.csv">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>
+    <None Update="FileImporter\TestFiles\Generic\CashTransactions\single_dividend.csv">
+      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+    </None>
     <None Update="FileImporter\TestFiles\Generic\CashTransactions\single_fee.csv">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>

GhostfolioSidekick/FileImporter/Generic/GenericParser.cs

@@ -23,12 +23,21 @@ public GenericParser(IGhostfolioAPI api) : base(api)
 				record.Id = $"{record.ActivityType}_{record.Symbol}_{record.Date.ToInvariantDateOnlyString()}_{record.Quantity.ToString(CultureInfo.InvariantCulture)}_{record.Currency}_{record.Fee?.ToString(CultureInfo.InvariantCulture)}";
 			}
 
+			var unitPrice = new Model.Money(CurrencyHelper.ParseCurrency(record.Currency), record.UnitPrice, record.Date);
+
+			if (record.Tax != null)
+			{
+				var totalWithTaxesSubtracted = (unitPrice.Amount * record.Quantity) - record.Tax.Value;
+				var newUnitPrice = totalWithTaxesSubtracted / record.Quantity;
+				unitPrice = new Model.Money(unitPrice.Currency, newUnitPrice, unitPrice.TimeOfRecord);
+			}
+
 			var order = new Model.Activity(
 				record.ActivityType,
 				asset,
 				record.Date,
 				record.Quantity,
-				new Model.Money(CurrencyHelper.ParseCurrency(record.Currency), record.UnitPrice, record.Date),
+				unitPrice,
 				new[] { new Model.Money(CurrencyHelper.ParseCurrency(record.Currency), record.Fee ?? 0, record.Date) },
 				TransactionReferenceUtilities.GetComment(record.Id, record.Symbol),
 				record.Id

GhostfolioSidekick/FileImporter/Generic/GenericRecord.cs

@@ -16,6 +16,9 @@ public class GenericRecord
 
 		public decimal? Fee { get; set; }
 
+		[CsvHelper.Configuration.Attributes.Optional]
+		public decimal? Tax { get; set; }
+
 		[CsvHelper.Configuration.Attributes.Optional]
 		public string? Id { get; set; }
 	}

README.md

@@ -157,7 +157,10 @@ Beside the supported exchanges and brokers there is also a generic format. This
 | Currency | The currency of the unitprice and fee |
 | Quantity | The amount of units |
 | UnitPrice | The paid price per unit |
-| Fee | The total fee paid for the transaction |
+| Fee | The total fee paid for the transaction. Is optional |
+| Tax | The total tax on the transaction, is used to adjust the unitprice. Is optional |
+| Description | A description, not used in ghostfolio itself. Is optional |
+| Id | The transaction id. Is optional |
 
 ##### Example