Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Docker images on PR #98

Closed
wants to merge 6 commits into from
Closed

Conversation

jdcmarques
Copy link

@jdcmarques jdcmarques commented Jan 10, 2024

Description

  • Allows for workflow to publish docker images tagged with ``pr-XXX`
  • Add comment on PR with image published
  • Trigger workflow when a PR is merged / closed and curl docker hub to delete old image.

Feel free to close this if not needed, but it makes it easier to test out temporary versions of the project

@VibeNL
Copy link
Owner

VibeNL commented Jan 10, 2024

Great idea. it is just not working yet. I myself am not that skilled at the github actions so if you could make it work, that would be great :).

@VibeNL VibeNL added the enhancement New feature or request label Jan 10, 2024
@jdcmarques
Copy link
Author

jdcmarques commented Jan 10, 2024

Now sure how GH Workflow interacts with secrets if opened from fork 😅
It would have to come from a branch in your repo, not a fork, I think

https://securitylab.github.com/research/github-actions-preventing-pwn-requests/

VibeNL added a commit that referenced this pull request Jan 11, 2024
VibeNL added a commit that referenced this pull request Jan 11, 2024
* Publish Docker images on PR. Clone of #98

* cleanup build file

* adding badge

* add issues: write as a permission
@VibeNL
Copy link
Owner

VibeNL commented Jan 11, 2024

@jdcmarques , I think i got it working on my own branch. Thanks for the initial implementation 👍

@VibeNL VibeNL closed this Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants