This repository has been archived by the owner on Aug 9, 2020. It is now read-only.
use AdvanceEncryptor to fix encrypting cache error #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is a working solution, thanks @ZDZN !!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RxCache interface methods always load from network when using @EncryptKey and @Encrypt. I thought that it must have an error when encrypting or decrypting the cache data, but when I run the test file, the result was all green.
Thus I directly use the Encryptor to encrypt and decrypt file in my testing android project, I found that the BuiltInEncryptor cannot decrypt the data.
Finally, I found some information about the encrypt method difference between java platform and android platform.
I replace the BuiltInEncryptor with AdvanceEncryptor in RxCacheModule, the new Encryptor can run the correct result on android platform and is also tested in java platform.
Now I uses my build in my android project and I hope this pull request can fix this bug.
Thank you for your nice library.