Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated webhook service port #1460

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Conversation

AndrewChubatiuk
Copy link
Collaborator

@AndrewChubatiuk AndrewChubatiuk commented Sep 9, 2024

made service port for webhook the same as pod port
can be related to
VictoriaMetrics/operator#1094

@github-actions github-actions bot added the operator operator helm chart related issue label Sep 9, 2024
@Haleygo
Copy link
Contributor

Haleygo commented Sep 9, 2024

As I understand, the old values are correct, but the user didn't expose 443 on their nodes for webhook svc?
If so, maybe we should provide a way to customize service port, wdyt?

@AndrewChubatiuk
Copy link
Collaborator Author

as we do not customize http service port, so guess there's no need to customize webhook one as well, just made the value of webhook port the same as on container in the same manner as we have for http

@AndrewChubatiuk AndrewChubatiuk merged commit f42b1e0 into master Sep 9, 2024
6 checks passed
@AndrewChubatiuk AndrewChubatiuk deleted the change-webhook-service-port branch September 9, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
operator operator helm chart related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants