distributed: major refactoring, use common templates #1520
Conversation
AndrewChubatiuk
requested review from
zekker6,
Haleygo and
f41gh7
as code owners
AndrewChubatiuk
force-pushed
the
refactor-distributed-chart
branch
from
25855ca
to
8426568
Compare
AndrewChubatiuk
force-pushed
the
refactor-distributed-chart
branch
from
8426568
to
d4bc969
Compare
| - `vmauthIngestGlobal` was changed to `write.global.vmauth` | ||
| - `vmauthQueryGlobal` was changed to `read.global.vmauth` |
There was a problem hiding this comment.
How about moving them into .global as global.vmauthIngest and global.vmauthQuery?
Since there shouldn't be other fields under write.global or global.write.
There was a problem hiding this comment.
global section in helm is special one, it's shared across all charts in release
charts/victoria-metrics-distributed/templates/per-az/vmagent.yaml
Outdated
Show resolved
Hide resolved
| - | ||
| # -- Availability zone name | ||
| name: zone-eu-1 | ||
| common: |
There was a problem hiding this comment.
I think components shouldn't share other spec except nodeSelector/affinitytopologySpreadConstraints, which could lead to misuse and it's better to not lead to that way.
How about changing this as a plain commonSpec instead of having common.spec?
There was a problem hiding this comment.
common.spec allows having then common.annotations and common.labels
| # Available parameters can be found [here](https://docs.victoriametrics.com/operator/api/index.html#vmagentspec) | ||
| spec: | ||
| remoteWriteSettings: | ||
| useMultiTenantMode: true |
There was a problem hiding this comment.
It's better to not set useMultiTenantMode=true by default, since it degrades vmagent performance.
There was a problem hiding this comment.
updated this
| vminsert: | ||
| serviceSpec: | ||
| spec: | ||
| clusterIP: None |
There was a problem hiding this comment.
Any reason for this setting?
There was a problem hiding this comment.
It was hardcoded in templates, looks like it's needed to provide to vmauth pod ips and move balancing to vmauth
charts/victoria-metrics-distributed/templates/per-az/vmauth-read-proxy.yaml
Show resolved
Hide resolved
| whenUnsatisfiable: ScheduleAnyway | ||
| write: | ||
| # -- Allow data ingestion to this zone | ||
| allow: true |
There was a problem hiding this comment.
How about unifying them to enable?
There was a problem hiding this comment.
enable is for resource creation and allow is for traffic routing
AndrewChubatiuk
force-pushed
the
refactor-distributed-chart
branch
from
73a18e9
to
56f579b
Compare
AndrewChubatiuk
force-pushed
the
refactor-distributed-chart
branch
from
56f579b
to
6bb6387
Compare
AndrewChubatiuk
force-pushed
the
refactor-distributed-chart
branch
from
b5e19ff
to
dcc3720
Compare
AndrewChubatiuk
force-pushed
the
refactor-distributed-chart
branch
from
dcc3720
to
3c05054
Compare
common.<component>.spec, which is merged with all*.<component>.spec, e.g:common.vmagent.specis merged withavailabilityZones[1].vmagent.specvmauthIngestGlobalwas changed towrite.global.vmauthvmauthQueryGlobalwas changed toread.global.vmauthavailabilityZones[*].allowIngestwas changed toavailabilityZones[*].write.allowavailabilityZones[*].allowReadwas changed toavailabilityZones[*].read.allowavailabilityZones[*].nodeSelectorwas moved toavailabilityZones[*].common.spec.nodeSelectoravailabilityZones[*].extraAffinitywas moved toavailabilityZones[*].common.spec.affinityavailabilityZones[*].topologySpreadConstraintswas moved toavailabilityZones[*].common.spec.topologySpreadConstraintsavailabilityZones[*].vmauthIngestwas moved toavailabilityZones[*].write.vmauthavailabilityZones[*].vmauthQueryPerZonewas moved toavailabilityZones[*].read.perZone.vmauthavailabilityZones[*].vmauthCrossAZQuerywas moved toavailabilityZones[*].read.crossZone.vmauth