convert custom range to vmrange map #71
Conversation
| @@ -57,6 +57,32 @@ type Histogram struct { | |||
| sum float64 | |||
| } | |||
|
|
|||
| // ConvertToVMRange distributes input value in a range (lower, upper] to a vmRange static buckets | |||
| func ConvertToVMRange(output map[string]float64, value, lower, upper float64) { | |||
There was a problem hiding this comment.
I don't understand how this function is intended to be used. Could you add an example with it's usage?
As far as I understand, it's possible to create a new histogram, write value into it and use visit method:
var hs metrics.Histogram
hs.Update(value)
hs.VisitNonZeroBuckets()There was a problem hiding this comment.
Idea of a function is to convert prometheus histogram ranges to VMranges. In an input we have distribution of values in a range without exact values (that's why approach you've suggested doesn't work), so here I just dividing prometheus range proportionally into VM buckets, e.g.:
input range 2..8 contains value 6 and it should be placed into three ranges 0..3, 3..6 and 6..9. According to a logic of a function to a first output range it will put (3-2)/(8-2) * 6 = 1, to a second (6-3)/(8-2) * 6 = 3 and third (8-6)/(8-2) * 6 = 2
There was a problem hiding this comment.
Seems like this function is here because it relies on many internal consts. The external caller can't possibly know about these costs, and neither can it assume these costs.
So the options are the following:
- Have this function, with a comment it is a helper function
- Expose internal consts, so the external caller could do the calculations on its own.
- Copy the consts to the caller codebase with assumption they won't ever change.
What do you think about this, @f41gh7 ?
There was a problem hiding this comment.
I'm ok with 3. @AndrewChubatiuk ?
|
implemented both native histograms and opentelemetry native histograms without conversion to static vm histograms ranges |
|
How about adding the following method to // UpdateWithBucket updates h with the given hits for the bucket on the `(lower, upper]` range
func (h *Histogram) UpdateWithBucket(hits uint64, lower, upper float64)The This method can be used for updating the
@AndrewChubatiuk , please provide links to the corresponding pull requests / commits here. This helps significantly during historical investigation of this pull request and other similar pull requests / issues. |
Added ability to convert custom range to a map of vmrange -> count map pairs
Required for VictoriaMetrics/VictoriaMetrics#5855