Use Getpagesize replace hard-coded page size #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryk-dk
requested review from
zekker6,
hagen1778,
AndrewChubatiuk,
f41gh7 and
Haleygo
AndrewChubatiuk
approved these changes
Jun 14, 2024
valyala
added a commit
that referenced
this pull request
Jul 16, 2024
…riteProcessMetrics() call It is enough to detect OS page size at the start and then use the detected value. This removes syscall overhead from every writeProcessMetrics() call. This is a follow-up for 7b14975 Updates #76 Updates VictoriaMetrics/VictoriaMetrics#6457
|
@zhengtianbao , @f41gh7 , @AndrewChubatiuk , please see the follow-up commit eba0da0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
process_resident_memory_bytesuse 4096 as hard-coded page sizes on all architectures, some of which are probably not right. Useos.Getpagesize()instead. This could fix issue: VictoriaMetrics/VictoriaMetrics#6457