added gossipConfig for VMAlertmanager #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f41gh7
reviewed
Jul 30, 2024
f41gh7
reviewed
Jul 30, 2024
| // ClientCAFile defines path to the pre-mounted file with CA | ||
| // mutually exclusive with ClientCASecretRef | ||
| ClientCAFile string `json:"client_ca_file,omitempty"` | ||
| CASecretRef *v1.SecretKeySelector `json:"ca_secret_ref,omitempty"` |
There was a problem hiding this comment.
I'd suggest to keep old naming, since it less confuses users.
For webserver tls config client_ca_file entry looks easy to understand and do not confuse, when you use documentation from http traffic configuration page https://prometheus.io/docs/alerting/latest/https/#http-traffic
Yes, it requires some copy-paste. But it's acceptable trade-off.
AndrewChubatiuk
force-pushed
the
am-mtls
branch
2 times, most recently
from
5ef1c42
to
39b9416
Compare
f41gh7
previously approved these changes
Jul 30, 2024
AndrewChubatiuk
changed the title
|
Done |
|
Thanks for contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added gossipConfig for VMAlertmanager