Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream aggregation: sync options dropInputLabels, `ignoreFirstInter… #1054

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

Haleygo
Copy link
Contributor

@Haleygo Haleygo commented Aug 1, 2024

…vals, ignoreOldSamples` from upstream, and support using configmap as the source of aggregation rules

address #1000

@Haleygo Haleygo requested a review from f41gh7 August 1, 2024 20:25
@Haleygo Haleygo requested a review from Amper as a code owner August 1, 2024 20:25
@Haleygo Haleygo force-pushed the enhance-aggregationconfig-support branch from 93cd9b2 to 0651129 Compare August 1, 2024 20:28
@Haleygo
Copy link
Contributor Author

Haleygo commented Aug 1, 2024

Related bug VictoriaMetrics/VictoriaMetrics#6744, vmagent will report error when configuring multiple -remoteWrite.streamAggr.ignoreFirstIntervals and it need to be fixed by upgrading VM to higher version.
Since this feature is not well-used yet, we can leave it to VM.

…vals`, `ignoreOldSamples` from upstream, and support using configmap as the source of aggregation rules
@Haleygo Haleygo force-pushed the enhance-aggregationconfig-support branch from 33fff29 to 7087082 Compare August 8, 2024 04:45
@Haleygo Haleygo merged commit d21e533 into master Aug 9, 2024
2 checks passed
@Haleygo Haleygo deleted the enhance-aggregationconfig-support branch August 9, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants