api/vmalertmanagerconfig: rework config validation #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adds more strict validation to VMAlertmanagerConfig * skip broken configurations from VMAlertmanager during config build * adds new status fields to the VMalertmanager config: * lastSyncError - that defines last error occured to the config during config generation * status - generic CRD status for health track * additional fields for sync error context, like last error timestamp and name of alertmanager * adds stack trace only to the panic level errors. It should reduce log noise * improves test coverage for VMAlertmanagerConfig validation webhook * removes required tlsConfig for email_configs * adds oauth2 and authorization to the VMAlertmanagerConfig `http_config` setting. * update docs/resources/vmalertmanager.md with proper secret examples and reflect last changes * replaces yaml based convertion for prometheus to vm AlertmanagerConfig receivers. It was required since validation tests needed proper yaml tags and our CRD tags is not compatible with prometheus one Signed-off-by: f41gh7 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#825