api: updates status definition for apps #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, applications had different json tags for `updataStatus` fields. clusterStatus for VMCluster for instance. Print fields for status pointed to the different fields. There were unused fields at status definitions. Code was copy-pasted for status updates. This commit addresses this issue with the following changes: * copy-pasted code replaced with generic implementation * after status patch, operator updates object version. This must resolve issues with conflicts during status update requests. * unused fields marked as deprecated an will be removed at upcoming releases * now all app components uses the same field `updateStatus`, that holds information about current app state * In addition new field `observedGeneration` was added, in the same way as it used at Kubernetes API. This change must help track CRD objects changes for 3rd party clients. Related issue: #1155 Signed-off-by: f41gh7 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, applications had different json tags for
updataStatusfields. clusterStatus for VMCluster for instance. Print fields for status pointed to the different fields. There were unused fields at status definitions. Code was copy-pasted for status updates.This commit addresses this issue with the following changes:
updateStatus, that holds information about current app stateobservedGenerationwas added, in the same way as it used at Kubernetes API. This change must help track CRD objects changes for 3rd party clients.Related issue:
#1155