operator: fix the behaviors of xxxScrapeConfigSelector and xxxNamespaceSelector
#1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haleygo
force-pushed
the
fix-vmagent-ScrapeConfigSelector
branch
from
546fcd4 to
41fde67
Compare
Haleygo
force-pushed
the
fix-vmagent-ScrapeConfigSelector
branch
from
41fde67 to
3d11332
Compare
3 tasks
Haleygo
force-pushed
the
fix-vmagent-ScrapeConfigSelector
branch
from
3d11332 to
89c8899
Compare
based on rules [here](https://docs.victoriametrics.com/operator/resources/vmagent/#scraping) 1. fix VMScrapeConfig reconcile: VMScrapeConfig is ignored in it's own reconcile when vmagentSpec.selectAllByDefault=false, since vmagent.IsUnmanaged() didn't include checks about VMScrapeConfig. But VMScrapeConfig could be pick up in vmagent's reconcile. 2. fix vmscrapeConfigNamespaceSelector in vmagent's reconcile, address scrapeConfigSelectors don't work as expected. VictoriaMetrics#7687 3. fix object selector when xxxNamespaceSelector matches nothing but selectAllByDefault=true. Before, it ignores the xxxNamespaceSelector that matches nothing. 4. limit the IsUnmanaged check scope in reconcile for each scrape CR.
Haleygo
force-pushed
the
fix-vmagent-ScrapeConfigSelector
branch
from
89c8899 to
2c7fdff
Compare
Haleygo
changed the title
vmagentSpec.ScrapeConfigSelector and…xxxScrapeConfigSelector and xxxNamespaceSelector
|
Thanks for contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on rules here
vmagentSpec.selectAllByDefault=false, sincevmagent.IsUnmanaged()didn't include checks about VMScrapeConfig. But VMScrapeConfig could be pick up in vmagent's reconcile.xxxNamespaceSelectormatches nothing butselectAllByDefault=true. Before, it ignores thexxxNamespaceSelectorthat matches nothing.IsUnmanagedcheck scope in reconcile for each scrape CR.