vmalert: remove notifier null check #813
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
, since
-notifier.url
is optional and is needed only if there are alerting rules.Also vmalert has
-notifier.blackhole
flag which supports evaluating alerting rules without sending any notifications to external receivers (eg. alertmanager), see #811.I think we can leave the check to vmalert itself.
Also, add minor sanity check for vmauth.
If
vmauth.Spec.Ingress.TlsSecretName
is used,vmauth.Spec.Ingress.TlsHosts
is also needed according to the code, otherwise IngressRule will be illegal.operator/controllers/factory/vmauth.go
Lines 413 to 425 in 9a481f2