vmscrapeconfig: support scrape_protocol option #877
+69
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewChubatiuk
force-pushed
the
scrape-protocol-config
branch
2 times, most recently
from
ed35d50
to
3219e02
Compare
Amper
requested changes
Feb 27, 2024
There was a problem hiding this comment.
Hey @AndrewChubatiuk, thanks for your contribution.
Couple of comments:
- Could you please describe this change in the section "Next release" of CHANGELOG?
- Could you add test for the new field?
AndrewChubatiuk
force-pushed
the
scrape-protocol-config
branch
2 times, most recently
from
f8207e0
to
f137aa6
Compare
AndrewChubatiuk
force-pushed
the
scrape-protocol-config
branch
from
f137aa6
to
7e56086
Compare
AndrewChubatiuk
force-pushed
the
scrape-protocol-config
branch
from
7e56086
to
0a41a70
Compare
AndrewChubatiuk
changed the title
AndrewChubatiuk
force-pushed
the
scrape-protocol-config
branch
from
0a41a70
to
9e2b000
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supports options added in VictoriaMetrics/VictoriaMetrics#5855