Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmscrapeconfig: authorization section in sd configs works properly … #949

Merged
merged 1 commit into from
May 7, 2024

Conversation

Amper
Copy link
Contributor

@Amper Amper commented May 7, 2024

…with empty type field (default value for this field is Bearer)

related links:

The default value for this field should work like "Bearer".

…with empty `type` field (default value for this field is `Bearer`)
@Amper Amper requested a review from Haleygo as a code owner May 7, 2024 14:42
@Amper Amper requested a review from f41gh7 May 7, 2024 14:43
Copy link
Collaborator

@f41gh7 f41gh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@f41gh7 f41gh7 merged commit d8c64d1 into master May 7, 2024
2 checks passed
@f41gh7 f41gh7 deleted the vmscrapeconfig-auth-type branch May 7, 2024 14:54
@f41gh7
Copy link
Collaborator

f41gh7 commented May 7, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants