Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmscrapeconfig: support max_scrape_size option #977

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

AndrewChubatiuk
Copy link
Contributor

f41gh7
f41gh7 previously approved these changes Jun 14, 2024
Copy link
Collaborator

@f41gh7 f41gh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewChubatiuk AndrewChubatiuk force-pushed the max-scrape-size branch 2 times, most recently from 351863b to bc838c7 Compare June 21, 2024 11:50
f41gh7
f41gh7 previously approved these changes Jun 21, 2024
Copy link
Collaborator

@f41gh7 f41gh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewChubatiuk AndrewChubatiuk changed the title vmpodscrape/vmservicescrape/vmnodescrape/vmstaticscrape: support max_scrape_size option vmscrapeconfig: support max_scrape_size option Jun 27, 2024
f41gh7
f41gh7 previously approved these changes Jun 27, 2024
Copy link
Collaborator

@f41gh7 f41gh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewChubatiuk
Copy link
Contributor Author

AndrewChubatiuk commented Jul 18, 2024

@f41gh7
since 1.102.0 is released, suppose this PR can be merged

Copy link
Collaborator

@f41gh7 f41gh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@f41gh7 f41gh7 merged commit dfbb6b1 into master Jul 18, 2024
@f41gh7 f41gh7 deleted the max-scrape-size branch July 18, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants