Use Appraisal in CI #1230

Spone · 2022-01-06T10:03:56Z

In my initial setup of Appraisal (#1225), I forgot to specify which gemfile to use in the CI configuration.

Spone · 2022-01-06T10:43:23Z

.github/workflows/ci.yml

@@ -46,7 +49,7 @@ jobs:
    - uses: actions/cache@v2
      with:
        path: vendor/bundle
-        key: gems-build-rails-${{ matrix.rails_version }}-ruby-${{ matrix.ruby_version }}-${{ hashFiles('**/Gemfile.lock') }}
+        key: gems-build-rails-${{ matrix.rails_version }}-ruby-${{ matrix.ruby_version }}-${{ hashFiles('**/gemfiles/rails_${{ matrix.rails_version }}.gemfile.lock') }}


I'm not sure this works as expected. 🤔

I think this part probably works alright. I'm inclined to believe it's setting BUNDLE_GEMFILE that isn't doing anything.

if caching was failing but the Gemfile was fine, GitHub Actions would try to install turbo-rails. I'm inclined to believe setting the Gemfile doesn't work, but caching still does, because there's no mention of turbo-rails or tailwindcss-rails in the logs, and the logs still say they're using a gem that has already been downloaded.

tailwindcss-rails now appear in the logs of the latest runs.

It doesn't look like the call to hashFiles is returning anything.

boardfish · 2022-01-06T11:04:22Z

Might it make sense to use Appraisal directly the same way it's mentioned inCONTRIBUTING.md, or does that complicate caching?

Spone · 2022-01-06T11:15:42Z

Might it make sense to use Appraisal directly the same way it's mentioned inCONTRIBUTING.md, or does that complicate caching?

Something like that?

- bundle exec rake
+ bundle exec appraisal rails-${{ matrix.rails_version }} rake

boardfish · 2022-01-06T14:01:33Z

Yeah. Come to think of it, I don't think it would cause caching issues, since it'd be installing the gems to the same place. You're right to be setting the cache keys based on the Rails version in use, though.

Spone · 2022-02-11T18:45:06Z

What do you think of this approach @joelhawksley & @BlakeWilliams?

Spone · 2022-02-14T23:14:53Z

I finally got CI to pass, with appraisal running the specs. It's currently running a fork of Appraisal, with this PR thoughtbot/appraisal#174 merged. So we should probably wait for the new version of Appraisal before going forward with this.

BlakeWilliams · 2022-02-15T14:31:04Z

Gemfile

@@ -8,6 +8,10 @@ rails_version = "#{ENV['RAILS_VERSION'] || 'main'}"
 gem "capybara", "~> 3"
 gem "rails", rails_version == "main" ? { git: "https://github.com/rails/rails", ref: "main" } : rails_version

+group :development, :test do
+  gem "appraisal", github: "excid3/appraisal", branch: "fix-bundle-env"


Is there a reason we shouldn't be using thoughtbot/appraisal?

Yes because the fix we need is not yet merged: thoughtbot/appraisal#174

Is there a way we can keep tabs on where @excid3's fork is at to ensure it's not susceptible to upstream issues with Appraisal?

Just FYI, I am skipping appraisal in CI right now and just setting BUNDLE_GEMFILE via matrix.

https://github.com/excid3/noticed/blob/master/.github/workflows/ci.yml#L28

boardfish

The call to hashFiles when setting the cache key isn't returning anything, so the cache can be overwritten by PRs.

boardfish · 2022-02-15T14:43:26Z

.github/workflows/ci.yml

@@ -46,7 +49,7 @@ jobs:
    - uses: actions/cache@v2
      with:
        path: vendor/bundle
-        key: gems-build-rails-${{ matrix.rails_version }}-ruby-${{ matrix.ruby_version }}-${{ hashFiles('**/Gemfile.lock') }}
+        key: gems-build-rails-${{ matrix.rails_version }}-ruby-${{ matrix.ruby_version }}-${{ hashFiles('**/gemfiles/rails_${{ matrix.rails_version }}.gemfile.lock') }}


It doesn't look like the call to hashFiles is returning anything.

Spone · 2022-02-15T15:01:21Z

The call to hashFiles when setting the cache key isn't returning anything, so the cache can be overwritten by PRs.

Hmmm... I think that we cannot hash the gemfiles/rails_****.gemfile.lock files because they are not committed, so they do not exist when the actions/cache@v2 action runs.

boardfish · 2022-02-15T15:15:42Z

I think it might be sufficient to use the Gemfiles themselves under gemfiles.

boardfish · 2022-02-28T10:41:37Z

Seems like the multiple calls to the cache action might be interfering with each other here.

boardfish · 2022-03-14T10:54:15Z

What needs doing to move this forward? Is there any way I can help? From what I can see it's probably just the gem caching that remains to be solved, but I'm not sure if you had any other plans @Spone.

Spone · 2022-03-14T11:07:09Z

What needs doing to move this forward? Is there any way I can help? From what I can see it's probably just the gem caching that remains to be solved, but I'm not sure if you had any other plans @Spone.

Yes I think the last blocking item is fixing the caching issue. If you have time to look into it that would be awesome!

Spone · 2022-03-16T11:26:02Z

I'll close this, as it's superseeded by #1308.

Spone and others added 6 commits January 6, 2022 11:03

Add BUNDLE_GEMFILE env to CI

f6a0410

Rename Appraisal rails-head to rails-main

a0ce71e

Add changelog entry

71de8e3

Add name to test job

ce22d93

Improve test job name format

9b6a841

Try to add rails version to hashFiles

100837d

Spone requested a review from boardfish January 6, 2022 10:38

Spone self-assigned this Jan 6, 2022

Spone commented Jan 6, 2022

View reviewed changes

Spone and others added 4 commits February 11, 2022 23:17

Merge branch 'main' into fix-appraisal-ci

bc6c1b5

Merge branch 'main' into fix-appraisal-ci

cf27290

Use appraisal rake instead of rake

3e48e10

Add bundle check & install step

bf847cf

Spone force-pushed the fix-appraisal-ci branch from 59f6c25 to bf847cf Compare February 14, 2022 22:35

Spone added 5 commits February 14, 2022 23:42

Try fix-bundle-env branch of excid3/appraisal

aec2556

Simplify appraisal bundle

68db61b

Readd bundle prior to appraisal commands

091a66e

Try with Appraisal 2.4.1 + excid3's PR

6e9c543

Stick with Rails ~> 7.0.0 in Gemfile.lock

1c03554

Spone mentioned this pull request Feb 14, 2022

Use bundler original env when running bundle commands. Fixes #173 thoughtbot/appraisal#174

Closed

Spone mentioned this pull request Feb 14, 2022

Add test coverage for use of turbo_stream helpers in components #1227

Merged

Switch back to excid3/appraisal fork

51d9b8e

BlakeWilliams reviewed Feb 15, 2022

View reviewed changes

boardfish reviewed Feb 15, 2022

View reviewed changes

Merge branch 'main' into fix-appraisal-ci

8ccf625

Spone added 2 commits February 15, 2022 16:16

Try updating the cache key hashFiles

eec9787

Use gemfile instead of gemfile.lock for hashFiles

2faa8de

boardfish mentioned this pull request Mar 14, 2022

Use appraisal gem in CI #1308

Merged

Spone closed this Mar 16, 2022

Spone deleted the fix-appraisal-ci branch March 16, 2022 11:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use Appraisal in CI #1230

Use Appraisal in CI #1230

Spone commented Jan 6, 2022 •

edited

Loading

Spone Jan 6, 2022 •

edited

Loading

boardfish Jan 6, 2022

Spone Feb 14, 2022

boardfish Feb 15, 2022

boardfish commented Jan 6, 2022

Spone commented Jan 6, 2022

boardfish commented Jan 6, 2022

Spone commented Feb 11, 2022

Spone commented Feb 14, 2022 •

edited

Loading

BlakeWilliams Feb 15, 2022

Spone Feb 15, 2022

boardfish Feb 15, 2022

excid3 Feb 15, 2022

boardfish left a comment

boardfish Feb 15, 2022

Spone commented Feb 15, 2022 •

edited

Loading

boardfish commented Feb 15, 2022

boardfish commented Feb 28, 2022

boardfish commented Mar 14, 2022

Spone commented Mar 14, 2022

Spone commented Mar 16, 2022

Use Appraisal in CI #1230

Use Appraisal in CI #1230

Conversation

Spone commented Jan 6, 2022 • edited Loading

Spone Jan 6, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

boardfish commented Jan 6, 2022

Spone commented Jan 6, 2022

boardfish commented Jan 6, 2022

Spone commented Feb 11, 2022

Spone commented Feb 14, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

boardfish left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Spone commented Feb 15, 2022 • edited Loading

boardfish commented Feb 15, 2022

boardfish commented Feb 28, 2022

boardfish commented Mar 14, 2022

Spone commented Mar 14, 2022

Spone commented Mar 16, 2022

Spone commented Jan 6, 2022 •

edited

Loading

Spone Jan 6, 2022 •

edited

Loading

Spone commented Feb 14, 2022 •

edited

Loading

Spone commented Feb 15, 2022 •

edited

Loading