-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use appraisal
gem in CI
#1308
Use appraisal
gem in CI
#1308
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,10 @@ | ||
name: CI | ||
|
||
on: [push, pull_request] | ||
on: | ||
pull_request: | ||
push: | ||
branches: | ||
- main | ||
|
||
jobs: | ||
benchmark: | ||
|
@@ -22,65 +26,50 @@ jobs: | |
bundle exec rake partial_benchmark | ||
bundle exec rake translatable_benchmark | ||
test: | ||
name: test (${{ matrix.rails_version }}, ${{ matrix.ruby_version }}, ${{ matrix.mode }}) | ||
runs-on: ubuntu-latest | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
rails_version: ["6.1", "7.0", "7.1", "main"] | ||
ruby_version: ["3.1", "3.2", "3.3"] | ||
mode: ["capture_patch_enabled", "capture_patch_disabled"] | ||
include: | ||
- rails_version: "6.1.4.4" | ||
ruby_version: "3.0" | ||
# Run against all previously supported Rails versions for Ruby 3.0 | ||
- ruby_version: "3.0" | ||
rails_version: "6.1" | ||
mode: "capture_patch_enabled" | ||
- rails_version: "7.0.2.3" | ||
ruby_version: "3.0" | ||
mode: "capture_patch_enabled" | ||
- rails_version: "main" | ||
ruby_version: "3.1" | ||
mode: "capture_patch_enabled" | ||
- rails_version: "7.1.1" | ||
ruby_version: "3.2" | ||
mode: "capture_patch_enabled" | ||
- rails_version: "main" | ||
ruby_version: "3.2" | ||
mode: "capture_patch_enabled" | ||
- rails_version: "6.1.4.4" | ||
ruby_version: "3.0" | ||
mode: "capture_patch_disabled" | ||
- rails_version: "7.0.2.3" | ||
ruby_version: "3.0" | ||
mode: "capture_patch_disabled" | ||
- rails_version: "main" | ||
ruby_version: "3.1" | ||
mode: "capture_patch_disabled" | ||
- rails_version: "7.1.1" | ||
ruby_version: "3.2" | ||
mode: "capture_patch_disabled" | ||
- rails_version: "main" | ||
ruby_version: "3.2" | ||
- ruby_version: "3.0" | ||
rails_version: "6.1" | ||
mode: "capture_patch_disabled" | ||
- rails_version: "7.1.1" | ||
ruby_version: "3.3" | ||
- ruby_version: "3.0" | ||
rails_version: "7.0" | ||
mode: "capture_patch_enabled" | ||
- ruby_version: "3.0" | ||
rails_version: "7.0" | ||
mode: "capture_patch_disabled" | ||
- rails_version: "main" | ||
ruby_version: "3.3" | ||
- ruby_version: "3.0" | ||
rails_version: "7.1" | ||
mode: "capture_patch_enabled" | ||
- ruby_version: "3.0" | ||
rails_version: "7.1" | ||
mode: "capture_patch_disabled" | ||
env: | ||
BUNDLE_GEMFILE: gemfiles/rails_${{ matrix.rails_version }}.gemfile | ||
steps: | ||
- uses: actions/[email protected] | ||
- name: Setup Ruby | ||
uses: ruby/setup-ruby@v1 | ||
with: | ||
ruby-version: ${{ matrix.ruby_version }} | ||
- uses: actions/cache@v3 | ||
with: | ||
path: vendor/bundle | ||
key: gems-build-rails-${{ matrix.rails_version }}-ruby-${{ matrix.ruby_version }}-${{ hashFiles('**/Gemfile.lock') }} | ||
bundler-cache: true | ||
- name: Build and test with Rake | ||
# Code-reloading isn't compatible with simplecov, so we need to run once | ||
# to collect coverage, and again to test reloads. | ||
run: | | ||
bundle config path vendor/bundle | ||
bundle update | ||
# Code-reloading isn't compatible with simplecov, so we need to run once | ||
# to collect coverage, and again to test reloads. | ||
boardfish marked this conversation as resolved.
Show resolved
Hide resolved
|
||
MEASURE_COVERAGE=true bundle exec rake test spec | ||
ENABLE_RELOADING=true bundle exec rake test spec | ||
bundle exec appraisal rails-${{ matrix.rails_version }} bundle | ||
MEASURE_COVERAGE=true bundle exec appraisal rails-${{ matrix.rails_version }} rake | ||
ENABLE_RELOADING=true bundle exec appraisal rails-${{ matrix.rails_version }} rake | ||
env: | ||
RAISE_ON_WARNING: 1 | ||
RAILS_VERSION: ${{ matrix.rails_version }} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
# This file was generated by Appraisal | ||
|
||
source "https://rubygems.org" | ||
|
||
gem "capybara", "~> 3" | ||
gem "rails", "~> 5.2.0" | ||
gem "rspec-rails", "~> 5" | ||
|
||
group :test do | ||
gem "cuprite", "~> 0.8" | ||
gem "puma", "~> 5" | ||
gem "selenium-webdriver", "~> 4" | ||
end | ||
|
||
group :development, :test do | ||
gem "appraisal", github: "thoughtbot/appraisal" | ||
end | ||
|
||
gemspec path: "../" |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
# This file was generated by Appraisal | ||
|
||
source "https://rubygems.org" | ||
|
||
gem "capybara", "~> 3" | ||
gem "rails", "~> 6.0.0" | ||
gem "rspec-rails", "~> 5" | ||
gem "tailwindcss-rails", "~> 2.0" | ||
|
||
group :test do | ||
gem "cuprite", "~> 0.8" | ||
gem "puma", "~> 5" | ||
gem "selenium-webdriver", "~> 4" | ||
end | ||
|
||
group :development, :test do | ||
gem "appraisal", github: "thoughtbot/appraisal" | ||
end | ||
|
||
gemspec path: "../" |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -255,15 +255,18 @@ def __vc_test_helpers_build_controller(klass) | |
|
||
def __vc_test_helpers_preview_class | ||
result = if respond_to?(:described_class) | ||
# :nocov: | ||
raise "`render_preview` expected a described_class, but it is nil." if described_class.nil? | ||
|
||
"#{described_class}Preview" | ||
# :nocov: | ||
else | ||
self.class.name.gsub("Test", "Preview") | ||
end | ||
result = result.constantize | ||
rescue NameError | ||
raise NameError, "`render_preview` expected to find #{result}, but it does not exist." | ||
end | ||
# :nocov: | ||
Comment on lines
+258
to
+270
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why were these changes necessary? I'd really prefer to avoid adding these comments. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'll try dropping them, but runs were failing due to coverage errors. I think this was the cause, though I'm not sure if anything in this PR in particular would've triggered it. |
||
end | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😎