Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Edit button must be of type button #142

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lorenzulrich
Copy link

If this plugin is placed inside a

HTML element, clicking the "edit" button triggers the form to be submitted because the default type for elements is "submit". By changing the edit button to type "button" explicitely, this problem can be solved.

If this plugin is placed inside a <form> HTML element, clicking the "edit" button triggers the form to be submitted because the default type for <button> elements is "submit". By changing the edit button to type "button" explicitely, this problem can be solved.
@qurben
Copy link

qurben commented Feb 20, 2019

Fixes #149

@mikkelcp1
Copy link

mikkelcp1 commented May 28, 2021

Hmm. I just corrected the same issue. It sure would have been nice if this pull request was completed.

Note this issue may also be with the upvote.

  // Upvotes
  var upvoteEl = $('<button/>', {
                'type': 'button',

mikkelcp1 added a commit to mikkelcp1/jquery-comments that referenced this pull request May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants