Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cobra and Packages Load instead of files #6

Merged
merged 5 commits into from
Sep 1, 2024

Conversation

stivesso
Copy link
Contributor

@stivesso stivesso commented Sep 1, 2024

This PR:

  1. shifts the cli to cobra (following result of this documented behavior)
  2. Enable loading of all structs in a package (so no more need to specify --src, which is thus deprecated, and the specified path can also either takes a package directory or a single source file)

I hit the issue urfave/cli#1950 with
urfave/cli, which makes it hard to Allow flags to come after arguments.

Hence, shifting to make use of Cobra as it allows a little more
flexibility.

Signed-off-by: Steve ESSO <[email protected]>
This enables loading a complete package, and is not limited anymore
to a single source file

Signed-off-by: Steve ESSO <[email protected]>
Signed-off-by: Steve ESSO <[email protected]>
Signed-off-by: Steve ESSO <[email protected]>
@stivesso stivesso force-pushed the stivesso/enterCobraAndPackages branch from 495c3c0 to 3aeae97 Compare September 1, 2024 02:48
@stivesso stivesso merged commit 8239e31 into main Sep 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants