Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deal-engine/finagle-postgres to GH repos. #262

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

ivanmoreau
Copy link

Hi! finagle/finagle-postgres is unmaintained. Should it be removed?

@github-actions
Copy link

github-actions bot commented Aug 10, 2023

Changed repositories:

deal-engine/finagle-postgres
finagle/finagle-postgres

Legends:
✅=Actor is a repo owner or an organization admin.
❔=Unable to validate. Requires manual validation.

@tgodzik
Copy link
Member

tgodzik commented Aug 10, 2023

Hi! finagle/finagle-postgres is unmaintained. Should it be removed?

Looks like maybe it should yeah. Could you do it in this PR? I think it might safer not to have two forks of the same repo, there have been issues around that previously.

@ivanmoreau
Copy link
Author

Hi! finagle/finagle-postgres is unmaintained. Should it be removed?

Looks like maybe it should yeah. Could you do it in this PR? I think it might safer not to have two forks of the same repo, there have been issues around that previously.

Done. Let me know if there is something left to do!

Copy link
Member

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@tgodzik tgodzik merged commit 8f8b2ab into VirtusLab:main Aug 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants