Fix mpf numbers #22
Open
Fix mpf numbers #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces calls to Player.Queue with calls to Player.ScheduleAction
Register changes to machine description with Unity Editor systems to ensure they are saved with the scene.
|
Hey man, thanks a lot but I'm currently on holidays so I'll go through everything when I'm back in 10 days! |
if it is in the streaming assets path
|
Hi @freezy , have you taken a look at any of my PRs yet? |
|
Not yet, but it's the next thing on my list. Currently working on Serum v2 :) |
|
Would you mind rebasing this? |
arthurkehrwald
force-pushed
the
fix-mpf-numbers
branch
from
07dc8d9
to
bcfa405
Compare
|
I'm a bit shaky with git. Not really sure if this is what you wanted xD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #21 by introducing a new serializable class called
MpfNameNumberDictionarythat permanently stores the number of each switch, coil, and light defined in the MPF machine description when it is transferred during initial setup. At runtime, this class is used to look up the numbers necessary to communicate with MPF.