-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vivecraft overrides GUI scale set by other mods #267
Comments
eh, we override the gui scale, to make guis easier to use in vr, since pointing at small buttons is a pain. If mods don't work at default mincraft scale that is on them imo, but we do have the setting to change it, uf the user wants to. |
if that is something that should work, with the vanilla guiscale set to auto, I can look into it |
I'm aware of that, but you do it in a way that breaks compatibility with other mods. We reset the Couldn't you just call |
hm, I can look into that |
Thanks! |
That won't work because it will get saved like that if you don't exit VR before closing the game. |
haven't looked into it yet |
so I looked into this, and I don't really see a way to fix this. and calling |
I could store the gui scale that gets saved to file, but that breaks with sodium, because that updates gui scale first, and then saves the settings. so couldn't detect if it's a mod changing stuff, or just the user setting the sodium setting |
I could maybe check the the gui scale before and after a screen got set |
@caoimhebyrne here that should fix it I think, if you could confirm it. |
Hey @fayer3, thanks for taking a look at this 🙂 |
At the moment, Vivecraft overrides the vanilla GUI scale of the Window. This causes incompatibilities with mods like ours, Essential, which would like to chose a GUI scale that fits the content best at the current resolution.
The user can change the
Settings > VR Settings > HUD and GUI Settings > VR GUI Scale
setting to anything other than Auto or 3 to fix this issue, but I think it would be better to stop overriding the GUI scale, so our changes (and probably other mods too) to the vanilla GUI scale can take effect.This is what Vivecraft and Essential looks like at the moment:
And here is what the Wardrobe is supposed to look like, as you can see, the entire right side of it is missing with Vivecraft (the second image in the table above is the Wardrobe with Vivecraft):
The text was updated successfully, but these errors were encountered: