Refactor/cleanup #284
Draft
Refactor/cleanup #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add mixin extras add back old names and comments add some javadoc some fixes/remove of unused stuff: fix seated crawl head floating remove tpose from mcvr, use the nullprovider for that renames `MCVR.hasThirdController` to `hasCameraTracker`, to reflect what it does fix key simulation with modifiers remove vsync change buffer reinit fix menu tooltips being stuck with keyboard use when the button disappears
move shaders into a shader helper includes FSAA, mixed reality and VR post/fov reduction move inMenuroom methods out of gamerenderer make ActionParams a record bunch of javadoc re sort the methods in MCVR fix thirdperson aspect being stuck at 16x9
more javadoc and variable renames moved lwjgl library check to MCOpenVR removed MCVR.postInit, since there is no point in having it not in the regular init anymore move touch hotbar after pose update, to not be a frame behind remove options reload from MCOpenVR init, and move the external camera config loading to the vr settings init change ActionParams back to regular class for backwards compatibility
ferriarnus
reviewed
Jun 18, 2024
common/src/main/java/org/vivecraft/client_vr/gameplay/VRPlayer.java
Outdated
Show resolved
Hide resolved
ferriarnus
reviewed
Jun 18, 2024
moves the settings file to the modloaders config folder
some logging fixes
remove legacy resource extraction some logging fixes
… refactor-cleanup
… used fix Keyboard/Radial buffer not resizing with the 1440p gui option
fix missing vanilla post effect, when disabling vr
… refactor-cleanup
change climbey blocklist command to check for valid blocks move the method to send stuff to all seen players into its own method, to not have duplicated code there
… reset everything warns in the log if something is invalid, and only sends valid blocks to clients
… refactor-cleanup
remove Xplat tick start/end events, since they are not used/needed
rename PlayerExtension.setItemInUseCountClient to setItemInUseRemainingClient, to correspond to the variable name rename some partialTicks to partialTick remove FrustumExtension.vivecraft$setCameraPosition(), use Frustum.prepare() instead, that does the same
…eOfSight` call, not just from enderman use the bigger visibility cone from the spigot extension don't cancel creeper swell goal, just change the distance check
fix arrow speed ignoring roomscale bow draw
move mod loaded checks to their Helper classes fix dynamicFPS mod getting quieter when window is unfocused in vr simplify NonNull redirects for the iris compat fix iris/oculus sometimes disabling AO in the menuworld remove player repositioning in optifine mixin. that is already done in levelrenderer fix resolution control 3 compat remove sodium options mixin for the graphic mode change, it is already checked every frame in the VRRenderer make all helper reflection variables match, with Class_Method/Field naming
fix debug winscreen not close able
fix pressing escape on the seated confirmation closing the screen, instead of canceling the confirmation
…ure manager since 1.20.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brings back old variable names and formatting
adds parchment mappings (closes #189)
adds mixin extras (not yet done completely)
ads javadoc to most methods
some of the other changes/fixes that happened:
fix seated crawl head floating
remove tpose from mcvr, use the null provider instead for that
removes MCVR.getHardwareType (since it is unused)
renames
MCVR.hasThirdControllertohasCameraTracker, to reflect what it doesfix key simulation with modifiers
remove vsync change buffer reinit
fix menu tooltips being stuck with keyboard use when the button disapears
move all shader rendering to
org/vivecraft/client_vr/render/helpers/ShaderHelper, includes FSAA, mixed reality and VR post/fov reductionremoved getFrameTiming/getCurrentTimeSecs from VRRenderer (unnecessary, replaced the one call that used it with Util.getMillis)
removed useless overrides from OpenVRStereoRenderer
move inMenuroom methods out of gamerenderer to MethodHolder
change logger in MixinConfig to a separate one
moved lwjgl library check to MCOpenVR
removed MCVR.postInit, since there is no point in having it not in the regular init anymore
move touchhotbar after pose update, to not be a frame behind
fix mirror aspect for third and center view
fix black in block overlay, not blocking with wide aspects
fix interactive wrist hotbar with changed main hand, and offset with reversed hands
remove options reload from mcopenvr init, and move the external camera config loading to the vr settings init
update editor config to allow one line ifs and specify how if wrapping should be like
fix auto open keyboard setting
fix radial/keaboard guiscale issue with max hud scale
add option to toggle headshot hitboxes
fixes #277
fixes #270
fixes #267
fixes #264
fixes #250