Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the client configs #183

Draft
wants to merge 17 commits into
base: Multiloader-1.20
Choose a base branch
from

Conversation

ferriarnus
Copy link
Member

Moving the client settings to the same system as the server configs

@Techjar
Copy link
Collaborator

Techjar commented Oct 20, 2023

What about all the existing GUIs with localized tooltips? And what about everyone's existing options files? I dunno, this just kinda seems like a "if it ain't broke don't fix it" situation.

@ferriarnus
Copy link
Member Author

I somewhat agree with you that working stuff should be left alone, however, having multiple systems for configs is a bit annoying. I've not looked into migrating the old ones, as I'm unsure if it's a big issue. For the guis, same as before: There's nothing really wrong with them, but multiple systems is hard to maintain.

@fayer3
Copy link
Member

fayer3 commented Oct 20, 2023

we can convert the old guis to use the new config system

@Techjar
Copy link
Collaborator

Techjar commented Nov 1, 2023

I guess I'll just be sad to see my VRSettings framework go away. I spent a lot of time refactoring it into an easy-to-work-with state. (You guys should have seen the old system lmao)

@ferriarnus
Copy link
Member Author

Yeah I get that, but I feel that toml is a bit of a nicer format (and is used by other mods so users will be familiar with it). I'm not a big fan of the massive enum, and annotations made it a bit more complex then needed imo. But the gui's can stay yeah. It's just that I wanted the server and client configs to have the same backend (and one which was hopefully less complex)

@fayer3
Copy link
Member

fayer3 commented Nov 1, 2023

yeah, we can keep the gui for now

@Techjar
Copy link
Collaborator

Techjar commented Nov 1, 2023

Yeah I don't think mod menu is as organized or user-friendly for the amount of settings we have, so at least keeping the GUI is kind of necessary. We'll have to convert all the localization strings though.

@Techjar
Copy link
Collaborator

Techjar commented Nov 1, 2023

annotations made it a bit more complex then needed imo

The reason for annotations was to avoid having to use getIntValue() or whatever all over the place. It can be used as just a regular field with the actual type. I'm still not a fan of the Fabric config system for that reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants