replace deprecated math classes with joml #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This touches a lot of stuff, definitely needs thorough testing. |
Techjar
reviewed
Oct 29, 2023
| @@ -1250,7 +1248,7 @@ void onOptionChange() { | |||
|
|
|||
| @Override | |||
| String getDisplayString(String prefix, Object value) { | |||
| return prefix + String.format("%.0f" + DEGREE, (float) value); | |||
| return prefix + String.format("%.0f°", (float) value); | |||
There was a problem hiding this comment.
Any reason for changing this? Minecraft renders the degree symbol just fine, and it takes up less space.
Please ignore, I read the diff incorrectly.
replaced all setTransposed calls with transpose
NicBOMB
force-pushed
the
joml
branch
2 times, most recently
from
9311bec
to
2a37df1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replacing PR #188 since I changed both the target and fork's branch.