Merge pull request #5 from Volicon/f/date-optimizations

Removed slow implicit date to number convertion
VoliJS · Jan 4, 2017 · 950b096 · 950b096
2 parents 2818722 + b9b43bc
commit 950b096
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 12 deletions.
diff --git a/index.js b/index.js
diff --git a/index.js.map b/index.js.map
diff --git a/src/record/attributes/date.ts b/src/record/attributes/date.ts
@@ -9,24 +9,28 @@ export class DateType extends AnyType {
     convert( value : any, a?, b?, record? ){
         if( value == null || value instanceof Date ) return value;
 
-        const date = new Date( value );
+        const date = new Date( value ),
+              timestamp = date.getTime();
 
-        if( isNaN( +date ) ){
+        if( timestamp !== timestamp ){
             this._log( 'warn', 'assigned with Invalid Date', value, record );
         }
 
         return date;
     }
 
     validate( model, value, name ) {
-        if( value != null && isNaN( +value ) ) return name + ' is Invalid Date';
+        if( value != null ){
+            const timestamp = value.getTime(); 
+            if( timestamp !== timestamp ) return name + ' is Invalid Date';
+        }
     }
 
     toJSON( value ) { return value && value.toISOString(); }
 
-    isChanged( a, b ) { return ( a && +a ) !== ( b && +b ); }
+    isChanged( a, b ) { return ( a && a.getTime() ) !== ( b && b.getTime() ); }
 
-    clone( value ) { return value && new Date( +value ); }
+    clone( value ) { return value && new Date( value.getTime() ); }
 }
 
 Date._attribute = DateType;