Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F/iterables #46

Merged
merged 9 commits into from
Oct 29, 2018
Merged

F/iterables #46

merged 9 commits into from
Oct 29, 2018

Conversation

gaperton
Copy link

@gaperton gaperton commented Apr 17, 2018

Initial implementation of #44. Quite dirty, but works. The review is needed to make it shorter and more efficient.

entries(), Symbol.iterator methods for both Record and Collection

values() method for the Collection (the record already has the legacy Backbone method with this name).

P.S. Need to think about deprecation of the rarely used (mostly unused) backbone methods, and moving them to the separate package.

@gaperton gaperton self-assigned this Apr 17, 2018
@gaperton gaperton requested a review from iterpugov April 17, 2018 01:46
Copy link

@iterpugov iterpugov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great for me

@gaperton gaperton merged commit 239fd50 into develop Oct 29, 2018
@gaperton gaperton deleted the f/iterables branch October 29, 2018 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants