Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tag model to be able to tag Event #285

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

yanicolivier
Copy link
Contributor

Q R
Type of contribution ? [Features]
Tickets (issues) concerned [278]

What have you changed ?

I have added a Tag model into volunteer app to be able to tag the events.

Verification :

  • My branch name respect the standard defined in CONTRIBUTING.md
  • All my commits respect the standard defined in CONTRIBUTING.md
  • This Pull-Request fully meets the requirements defined in the issue
  • I added or modified the attached tests
  • I added or modified the documentation

@coveralls
Copy link

coveralls commented Jan 15, 2021

Coverage Status

Coverage remained the same at 0.0% when pulling 6c49e64 on yanicolivier:feature-tags_events into 0ce8df0 on Volontaria:develop.

Copy link
Contributor

@RignonNoel RignonNoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yanicolivier Great job!

Here are the last things i thing we miss to finish this nice feature!

Test that we can filter the event by tag (would be nice to be sure it work :p)
Test that the tag are correctly created when creating an Event with tag directly
Test that we can add existing tag during event creation (and that it does not create a duplicated tag)
Test that the tag are correctly created when updating an Event with tag directly
Test that we can add existing tag during event update (and that it does not create a duplicated tag)

api_volontaria/apps/volunteer/models.py Outdated Show resolved Hide resolved
@yanicolivier yanicolivier force-pushed the feature-tags_events branch 3 times, most recently from f4403be to cf57f0f Compare January 18, 2021 14:04
@yanicolivier
Copy link
Contributor Author

@RignonNoel I'm facing a problem with this : Test that we can add existing tag during event creation (and that it does not create a duplicated tag)

I have created and commented a test line 144 of test_view_events.py.

Using WritableNestedModelSerializer seem to create the problem that I cannot add in a m2m an array of link to existing tags.

I have tried several approches to POST a new event with existing TAG without result. It's always asking to enter the name of the tag.

A strategy would be appreciated !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants