Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add file to notebook #444

Merged
merged 5 commits into from
Sep 7, 2023
Merged

chore: add file to notebook #444

merged 5 commits into from
Sep 7, 2023

Conversation

valeriiashmyhlo
Copy link
Contributor

@valeriiashmyhlo valeriiashmyhlo commented Sep 7, 2023 •
edited
Loading

RELATED TICKETS

  • asana/app-issues...

RELATED PRs

  • web/app-core/publish...

CHANGELOG

  • Add new file to a jupyter notebook
  • Slack thread

TESTS

  • describe your test strategy

COMMENTS

  • any other business

ministrudels
ministrudels requested changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@ministrudels ministrudels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Users wont be able to read that notebook while dat-support is a private repo

@valeriiashmyhlo valeriiashmyhlo merged commit 422e134 into master Sep 7, 2023
3 of 4 checks passed
@valeriiashmyhlo valeriiashmyhlo deleted the chore-update-notes branch September 7, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubbuskiewicz jakubbuskiewicz jakubbuskiewicz approved these changes

@ministrudels ministrudels ministrudels approved these changes

Assignees
No one assigned
Labels
echoes/effort: XS Very low effort changes (M * 0.2) echoes/intent: feedback echoes/intent: improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@valeriiashmyhlo @ministrudels @jakubbuskiewicz