fix: avoid double-freeing due to copy in io align unit test

VowpalWabbit · Feb 1, 2024 · 5deef6b · 5deef6b
1 parent 59197c3
commit 5deef6b
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/vowpalwabbit/core/tests/io_alignment_test.cc b/vowpalwabbit/core/tests/io_alignment_test.cc
@@ -24,7 +24,16 @@ struct positioned_ptr
       : allocation(allocation), allocation_unit(malloc(allocation)), p(reinterpret_cast<int8_t*>(allocation_unit))
   {
   }
-  ~positioned_ptr() { free(allocation_unit); }
+  positioned_ptr(const positioned_ptr&) = delete;
+  positioned_ptr(positioned_ptr&& original) : allocation(original.allocation), allocation_unit(original.allocation_unit)
+  {
+    original.allocation_unit = nullptr;
+  }
+
+  ~positioned_ptr()
+  {
+    if (allocation_unit != nullptr) { free(allocation_unit); }
+  }
 
   void realign(align_t alignment, align_t offset)
   {