Skip to content

Commit

Permalink
fix: ParseInsitu is not compatable with rlclientlib C# bindings
Browse files Browse the repository at this point in the history
  • Loading branch information
bassmang committed Nov 17, 2023
1 parent 2849b3b commit bee5cec
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions vowpalwabbit/json_parser/src/parse_example_slates_json.cc
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ void VW::parsers::json::details::parse_slates_example_json(const VW::label_parse
VW::example_factory_t example_factory, const std::unordered_map<uint64_t, VW::example*>* dedup_examples)
{
Document document;
document.ParseInsitu(line);
document.Parse(line);

// Build shared example
const Value& context = document.GetObject();
Expand All @@ -248,7 +248,7 @@ void VW::parsers::json::details::parse_slates_example_dsjson(VW::workspace& all,
const std::unordered_map<uint64_t, VW::example*>* dedup_examples)
{
Document document;
document.ParseInsitu(line);
document.Parse(line);
// Build shared example
const Value& context = document["c"].GetObject();
VW::multi_ex slot_examples;
Expand Down

0 comments on commit bee5cec

Please sign in to comment.