Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Flatbuffer format #3989

Merged
merged 50 commits into from
Feb 9, 2024
Merged
Changes from 1 commit
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
2530d11
Updated the schema
Sharvani2002 Jun 20, 2022
1c35380
Updated the parser according to new schema and usecase
Sharvani2002 Jun 20, 2022
573e935
Updated the test
Sharvani2002 Jun 20, 2022
83ca039
Added few scripts for frequently used commands
Sharvani2002 Jun 20, 2022
8ccb306
Updated code according to new schema and usecases
Sharvani2002 Jun 20, 2022
1b1fc03
Merge branch 'VowpalWabbit:master' into exp_schema
Sharvani2002 Aug 12, 2022
0b8ddea
Updated the parser
Sharvani2002 Aug 13, 2022
eddd529
Optimized the flatbuffer parser
Sharvani2002 Aug 14, 2022
e51eb88
Optimized the flatbuffer parser
Sharvani2002 Aug 14, 2022
c9af08d
Merge branch 'VowpalWabbit:master' into exp_schema
Sharvani2002 Sep 16, 2022
17f786b
Added error checks for parsing namespace
Sharvani2002 Sep 23, 2022
6107c83
Updated code to propagate error code
Sharvani2002 Oct 1, 2022
2c96012
Minor fix
Sharvani2002 Oct 1, 2022
637dcac
updated api_status
Sharvani2002 Oct 2, 2022
7420296
Updated error code return and fb parser tests
Sharvani2002 Oct 2, 2022
b179b61
Added api_status option
Sharvani2002 Oct 2, 2022
dc49acd
Updated error code return and minor fixes
Sharvani2002 Oct 2, 2022
45a41a2
merge in master
bassmang Nov 7, 2023
e446152
lint
bassmang Nov 7, 2023
44d01b0
Merge branch 'master' into exp_schema
lokitoth Jan 19, 2024
7a4b013
fix: memory leak on api_status in flatbuffer_to_examples
lokitoth Jan 19, 2024
550da45
fix: Re-create the Flatbuffer test input files to match new schema
lokitoth Jan 20, 2024
bcbbe89
feat: enable running/debugging CTests in VS Code
lokitoth Jan 20, 2024
cf3838e
Merge remote-tracking branch 'origin/master' into exp_schema
lokitoth Jan 30, 2024
85a501a
fix: flatbuffer reads need specific alignments
lokitoth Jan 31, 2024
dcec8a6
fix: remove user build scripts
lokitoth Jan 31, 2024
85f8999
fix: pass api_status through the tree of calls in fb_parser
lokitoth Jan 31, 2024
7ea997a
fix: maxos build breaks due to imprecise use of constexpr
lokitoth Jan 31, 2024
db5ee3d
fix: lint
lokitoth Jan 31, 2024
c14bcdc
fix: unit test break due to improper error-code semantics
lokitoth Jan 31, 2024
926ef5d
fix: python lint
lokitoth Jan 31, 2024
1b16e13
feat: add unit tests for desired_align
lokitoth Feb 1, 2024
81d11ed
fixup: fix partial commit
lokitoth Feb 1, 2024
405a5b4
fix: C++ lint
lokitoth Feb 1, 2024
d6544db
fix: early termination in fb tests due to misaligned read
lokitoth Feb 1, 2024
59197c3
chore: c++ lint
lokitoth Feb 1, 2024
5deef6b
fix: avoid double-freeing due to copy in io align unit test
lokitoth Feb 1, 2024
dfef8c9
fix: desired_align test was broken in windows/debug
lokitoth Feb 1, 2024
98ce35d
feat: implement additional tests for coverage
lokitoth Feb 6, 2024
f9cb076
fix: test validation logic was indexing incorrectly
lokitoth Feb 6, 2024
2ab5570
feat: basic io_buf::buf_read alignment tests
lokitoth Feb 6, 2024
93992f1
chore: fix C++ lint
lokitoth Feb 6, 2024
f7496ba
fix: Clean up empty files and copyright headers
lokitoth Feb 6, 2024
183a760
fix: memory leak in run_parse_and_verify_test
lokitoth Feb 6, 2024
157057c
fix: Typo causing build-break
lokitoth Feb 6, 2024
ad2b128
fix: another small memory leak in test code
lokitoth Feb 6, 2024
ce1cefb
feat: Add more testing to the fb parsing logic
lokitoth Feb 7, 2024
8cb4998
feat: Implement tests for uncovered label types
lokitoth Feb 7, 2024
52d7e9b
fix: Address review feedback
lokitoth Feb 8, 2024
579b28a
fix: Update run_test reference data for VW CLI help
lokitoth Feb 8, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions vowpalwabbit/core/include/vw/core/api_status.h
Original file line number Diff line number Diff line change
Expand Up @@ -260,3 +260,15 @@ int report_error(status_builder& sb, const First& first, const Rest&... rest)
return sb << VW::experimental::error_code::code##_s

#endif // RETURN_ERROR_LS

rajan-chari marked this conversation as resolved.
Show resolved Hide resolved
#ifndef RETURN_IF_FAIL
/**
* @brief Error reporting macro to test and return on error
*/
#define RETURN_IF_FAIL(x) \
do \
{ \
int retval__LINE__ = (x); \
if (retval__LINE__ != 0) { return retval__LINE__; } \
} while (0)
#endif