Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docker build and github actions, remove DGA from default compilation #219

Draft
wants to merge 15 commits into
base: dev
Choose a base branch
from
Draft

Update docker build and github actions, remove DGA from default compilation #219

wants to merge 15 commits into from

Conversation

frikilax
Copy link
Member

@frikilax frikilax commented Mar 11, 2021 •
edited
Loading

✨ Pull Request Template

‼️ Once all the checklist is done you have to:

  • stash merge this pull request
  • delete the corresponding branch
  • close the associated issue

📃 Type of change

Please delete options that are not relevant.

Bug fix: non-breaking change which fixes an issue.

💡 Related Issue(s)

  • none

✒️ Description

Fixes

  • fix deprecated use of set-env in github actions

Changes

  • remove DGA from default CMake compilation
  • remove tensorflow from docker building
  • use armadillo version 9.900.1 (for mlpack 3.4.0)
  • use Yara version 4.0.5
  • concentrate actions in a single file for releases
  • improve Dockerfile with filter release images (minimal images with a single filter)

✔️ Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • (If other changes) I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes

  • 🙋 I certify on my honor that all the information provided is true, and I've done all I can to deliver a high quality code

@frikilax frikilax requested a review from HugoSoszynski March 11, 2021 22:19
@frikilax frikilax self-assigned this Mar 11, 2021
@HugoSoszynski HugoSoszynski added this to the Version 1.6 milestone Mar 13, 2021
frikilax and others added 14 commits March 25, 2021 11:48
@frikilax
GITHUB ACTIONS::IMPROVEMENTS:: remove set-env deprecated command
63b690f
@frikilax
GITHUB ACTIONS::TEMPORARY:: add docker branch to trigger
d678175
@frikilax
FILTERS::DEPRECATION:: remove DGA from default compilation
9ce7985 
- DGA removed from default cmake filters to compile
- DGA/tensorflow removed from compilation on docker builds
@frikilax
GITHUB ACTIONS::IMPROVEMENTS:: remove set-env deprecated command (rel…
4a4b0b6 
…ease actions)
@frikilax
GITHUB ACTIONS::TEMPORARY:: add docker branch to trigger (release act…
501971e 
…ions)
@frikilax
GITHUB ACTIONS::FIX:: fix armadillo version
aae9829
@frikilax
GITHUB ACTIONS::FIX:: use armadillo 9.900.1 for Mlpack 3.4.0
f1915ca
@frikilax
GITHUB ACTIONS::IMPROVEMENTS:: concentrate jobs in a single file
f77152d
@frikilax
GITHUB ACTIONS::FIX:: try valid syntax for if
0b90a7c
@frikilax
GITHUB ACTIONS::FIX:: remove 'IMAGE_TAG' envvar
ca3e899
@frikilax
DOCKER::FIX:: Fix copy from faup
122da4a
@frikilax
ACTIONS::TEMPORARY:: Remove 'docker' from branches that trigger actions
341fdc3
@frikilax
ACTIONS::UPDATE:: Use Yara v4.0.5
44355e3
@frikilax
DOCKER::IMPROVEMENTS:: to dockerfile
5f8355f
@frikilax frikilax marked this pull request as draft January 12, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HugoSoszynski HugoSoszynski Awaiting requested review from HugoSoszynski

At least 1 approving review is required to merge this pull request.

Assignees

@frikilax frikilax

Labels
None yet
Projects
None yet
Milestone
Version 1.6
Development

Successfully merging this pull request may close these issues.
2 participants
@frikilax @HugoSoszynski