Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis improvements and fixes #221

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from
Draft

Redis improvements and fixes #221

wants to merge 4 commits into from

Conversation

frikilax
Copy link
Member

@frikilax frikilax commented Mar 24, 2021

✨ Redis improvements and fixes

πŸ“ƒ Type of change

Please delete options that are not relevant.

Bug fix: non-breaking change which fixes an issue.
New feature: non-breaking change which adds functionality.

πŸ’‘ Related Issue(s)

  • none

βœ’οΈ Description

Fixed

  • fbuffer: checks if key exists and is a SET (not a LIST) before potentially cleaning it at startup
  • Redis Manager: TestIsManager(ip, port) logic was inverted
  • Tests: check_start_stop did not check if filter is running properly

Added

  • Alert Manager: possibility to connect to Redis via IP:port
  • fbuffer/fconnection/fend/fsession/ftanomaly/ftest: possibility to connect to Redis via IP:port

TODO

  • update documentation
  • add tests for Redis through IP (at least in base tests)

🎯 Test Environments

FreeBSD (version)

  • Redis (version)
  • Boost (version)
  • clang++ (or g++) (version)
  • CMake (version)
  • Python (version)

Ubuntu (version)

  • Redis (version)
  • Boost (version)
  • g++ (or clang++) (version)
  • CMake (version)
  • Python (version)
  • Valgrind (version)

βœ”οΈ Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • (If new filter) I have added corresponding page to the documentation
  • (If other changes) I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

  • πŸ™‹ I certify on my honor that all the information provided is true, and I've done all I can to deliver a high quality code

@frikilax frikilax changed the base branch from master to dev July 1, 2021 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant