Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API_PARSER][CYBEREASON] Fix multiple points #454

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

nlancon
Copy link
Contributor

@nlancon nlancon commented Aug 30, 2024

Fixed

  • [API_PARSER][CYBEREASON] Fix multiple points:
    • Add a "to" argument to fetch malwares
    • Add two distinct timestamps for malops & malwares
    • Increment timestamp if no logs where retrieved during the last 24hours

@nlancon nlancon added the bug Something isn't working label Aug 30, 2024
@nlancon nlancon self-assigned this Aug 30, 2024
frikilax
frikilax previously approved these changes Sep 2, 2024
vulture_os/services/frontend/models.py Outdated Show resolved Hide resolved
vulture_os/toolkit/api_parser/cybereason/cybereason.py Outdated Show resolved Hide resolved
vulture_os/toolkit/api_parser/cybereason/cybereason.py Outdated Show resolved Hide resolved
vulture_os/toolkit/api_parser/cybereason/cybereason.py Outdated Show resolved Hide resolved
ELDiablO59152
ELDiablO59152 previously approved these changes Sep 19, 2024
Copy link
Member

@ELDiablO59152 ELDiablO59152 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good.

@ELDiablO59152 ELDiablO59152 changed the base branch from master to dev September 19, 2024 15:22
@ELDiablO59152 ELDiablO59152 dismissed their stale review September 19, 2024 15:22

The base branch was changed.

@ELDiablO59152 ELDiablO59152 changed the base branch from dev to release/2.16.0 September 19, 2024 15:24
@ELDiablO59152 ELDiablO59152 merged commit 20368de into release/2.16.0 Sep 23, 2024
5 checks passed
@ELDiablO59152 ELDiablO59152 deleted the fix_cybereason_835 branch September 25, 2024 08:17
frikilax pushed a commit that referenced this pull request Sep 25, 2024
- [API_PARSER][CYBEREASON] Fix multiple points:
    - Add a "to" argument to fetch malwares
    - Add two distinct timestamps for malops & malwares
- Increment timestamp if no logs where retrieved during the last 24hours

---------

Co-authored-by: Nicolas Lançon <[email protected]>
Co-authored-by: Fabien Amelinck <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants