Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(testing): Variabilize settings and implement django tests #477

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

feat(testing): Variabilize settings and implement django tests #477

wants to merge 8 commits into from

Conversation

frikilax
Copy link
Member

@frikilax frikilax commented Jan 3, 2025

Removed

  • [TESTS] Remove old 'testing' folder

Added

  • [TESTS] [SYSTEM] Implement Network test cases
  • [TESTS] [WORKFLOW] Implement Workflow test cases

Fixed

  • [SYSTEM] [MONGODB] Always refer to settings to connect to mongodb

Changed

  • [SYSTEM] [PATHS] Variabilize all system paths and allow to configure them from settings
  • [SYSTEM] [SETTINGS] Use Hostname value from Django settings
  • [SYSTEM] [SETTINGS] Allow to configure project with django-environ

ELDiablO59152
ELDiablO59152 reviewed Jan 13, 2025
View reviewed changes
Copy link
Member

@ELDiablO59152 ELDiablO59152 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each commit looks fine so far, no regression detected after install.
I want to test the tests routine before approval.

ELDiablO59152
ELDiablO59152 previously approved these changes Jan 15, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ELDiablO59152 ELDiablO59152 ELDiablO59152 left review comments

@jjourdin jjourdin Awaiting requested review from jjourdin

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frikilax @ELDiablO59152