-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make /EzVz and /ezvz links legacy intercompatible #99
base: gh-pages
Are you sure you want to change the base?
Conversation
b449949
to
d0b98d1
Compare
@tehmaze Just confirming you've also checked the contents of these changes? The topic was a bit controversial for a hot second. |
Confirmed that all the old and new links sort-of work as expected (in that they generate the correct page contents, but I had somehow expected to be redirected). All in all, good enough for now. |
Were there pages that didn't redirect as expected, then? Did you test this with a local deployment? Edit: I just checked with a local deployment and it looks like all the redirects work. Do we merge this and put those fixed text links in a new PR, or fix those in here? |
this also fixes pbsuper's oversights
d0b98d1
to
bbd48c0
Compare
New commits were added after review
cherry-pick from pull request #93 "Minor fixes to documentation STL's and text" ...
... to a new PR so it can either stay open or be handled separately from the other minor fixes as those minor fixes turned out to not be so minor after all.
To view the files changed in this PR, please see https://github.com/VzBoT3D/docs/pull/99/files
The contents of this PR are as follows:
Examples:
/ezvz/faq
and/ezvz/FAQ
/ezvz/filaments
and/ezvz/Filaments
Example:
Pbsuper changed
/ezvz/how-it-works/customers
to/EzVz/how-it-works/customers
while the original URL (pre-edits) was actually/EzVz/how_to_customers
The aliases implemented above set the url's to the more SEO-friendly ones, while keeping compatibility with the old url's the bot (likely) uses