Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make /EzVz and /ezvz links legacy intercompatible #99

Open
wants to merge 2 commits into
base: gh-pages
Choose a base branch
from

Conversation

HumbleDeer
Copy link
Contributor

@HumbleDeer HumbleDeer commented Oct 10, 2023

cherry-pick from pull request #93 "Minor fixes to documentation STL's and text" ...
... to a new PR so it can either stay open or be handled separately from the other minor fixes as those minor fixes turned out to not be so minor after all.

To view the files changed in this PR, please see https://github.com/VzBoT3D/docs/pull/99/files

The contents of this PR are as follows:

  • Adds aliases to pages to restore functionality in the bot
  • Adds aliases to pages to make them dummy-proof;
    Examples:
    • add both /ezvz/faq and /ezvz/FAQ
    • add both /ezvz/filaments and /ezvz/Filaments
  • Adds slugs and removes permalinks (improves function for the GitHub Pages DNS)
  • Adds comments about what were the original links and which are the edited ones.
  • addm. above: Fixes some residual issues in pbsuber's quick fixes (multiple commits);
    Example:
    Pbsuper changed /ezvz/how-it-works/customers to /EzVz/how-it-works/customers while the original URL (pre-edits) was actually /EzVz/how_to_customers
    The aliases implemented above set the url's to the more SEO-friendly ones, while keeping compatibility with the old url's the bot (likely) uses

@HumbleDeer
Copy link
Contributor Author

I'd like both @pbsuper and @StaticFX 's (positive) review on this PR before merging.

tehmaze
tehmaze previously approved these changes Oct 11, 2023
@HumbleDeer
Copy link
Contributor Author

@tehmaze Just confirming you've also checked the contents of these changes? The topic was a bit controversial for a hot second.

@tehmaze
Copy link
Member

tehmaze commented Oct 11, 2023

Confirmed that all the old and new links sort-of work as expected (in that they generate the correct page contents, but I had somehow expected to be redirected). All in all, good enough for now.

@HumbleDeer
Copy link
Contributor Author

HumbleDeer commented Oct 11, 2023

Confirmed that all the old and new links sort-of work as expected (in that they generate the correct page contents, but I had somehow expected to be redirected). All in all, good enough for now.

Were there pages that didn't redirect as expected, then? Did you test this with a local deployment?

Edit: I just checked with a local deployment and it looks like all the redirects work.
I did also, during this, discover I didn't change any of the URL's that link to /EzVz pages but that's also the only reason I could see the redirects at work, working properly. I'll try and fix these links soon ish, hopefully. This is implemented in a succeeding commit.

Do we merge this and put those fixed text links in a new PR, or fix those in here?

this also fixes pbsuper's oversights
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants