Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update award-index_statistics.sparql to make the graphic more straightforward #2393

Closed
wants to merge 1 commit into from

Conversation

Adafede
Copy link
Contributor

@Adafede Adafede commented Dec 11, 2023

Description

When looking at the current https://scholia.toolforge.org/award/#statistics, the first impression is that gender balance is "not so bad" as it seems there are quite some points above a "1/1 line", but this is heavily biased because the x and y axis do not share the same maximum.
This PR aims at fixing this.

Caveats

Currently, the manual max value has been set to 2,000.

Please list anything which has been left out of this PR or which should be considered before this PR is accepted
Check any of the following which apply:

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
    • I have made corresponding changes to the documentation
  • This change requires new dependencies (please list)

If you make changes to the Python code

  • My code passes the tox check, I can receive warnings about tests, documentation or both

Testing

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have not used code from external sources without attribution
  • I have considered accessibility in my implementation
  • There are no remaining debug statements (print, console.log, ...)

@Adafede
Copy link
Contributor Author

Adafede commented Dec 11, 2023

See https://w.wiki/8TqV (proposal) for comparison with https://w.wiki/8TqY (current)

@Adafede
Copy link
Contributor Author

Adafede commented Jan 11, 2024

Same strategy could be applied to some other graphics (e.g. https://scholia.toolforge.org/publisher/Q233358#citations-works, just landed on it randomly)

@fnielsen
Copy link
Collaborator

fnielsen commented Feb 6, 2024

Cherry-picked 974b55a

@fnielsen fnielsen closed this Feb 6, 2024
@Adafede Adafede deleted the patch-1 branch April 20, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants