Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spec] Network revocation patches for WebSocket and WebTransport APIs #206

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[Spec] Network revocation patches for WebSocket and WebTransport APIs #206

wants to merge 5 commits into from

Conversation

blu25
Copy link
Collaborator

@blu25 blu25 commented Jan 10, 2025 •
edited by pr-preview bot
Loading

This ensures that the following things happen for both WebTransport and WebSocket objects:

  • All open connections associated with a context are closed when untrusted network access is revoked.
  • New connections cannot be created after network access is revoked.

Preview | Diff

@blu25 blu25 requested a review from VergeA January 13, 2025 19:48
@blu25 blu25 marked this pull request as ready for review January 13, 2025 19:48
VergeA
VergeA reviewed Jan 14, 2025
View reviewed changes
spec.bs Outdated Show resolved Hide resolved
VergeA
VergeA reviewed Jan 14, 2025
View reviewed changes
spec.bs Show resolved Hide resolved
@VergeA
Copy link
Collaborator

VergeA commented Jan 14, 2025

LGTM % 1 comment

@blu25 blu25 requested a review from VergeA January 16, 2025 22:06
VergeA
VergeA approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@VergeA VergeA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@blu25 blu25 requested a review from domfarolino January 17, 2025 15:56
domfarolino
domfarolino reviewed Jan 18, 2025
View reviewed changes
spec.bs Outdated Show resolved Hide resolved
@blu25 blu25 requested a review from domfarolino January 27, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VergeA VergeA VergeA approved these changes

@domfarolino domfarolino Awaiting requested review from domfarolino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blu25 @VergeA @domfarolino