Support Observer callback union for subscription #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
added a commit
that referenced
this pull request
Nov 29, 2023
SHA: cfffd49 Reason: push, by domfarolino Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #71. The WebIDL Standard is now poised to support typedef unions between dictionary and callback types, which would enables a highly desired ergonomic feature: subscribing with just a callback instead of a full-blown
Observerdictionary. See whatwg/webidl#1353 and #71 (comment). The work is just waiting on another implementer besides Chromium, which we may be able to get via this proposal, which is a concrete user of this proposed Web IDL behavior.Work is underway to update the Chromium implementation to match this as well: https://chromium-review.googlesource.com/c/chromium/src/+/5071992
Preview | Diff