Update Privacy section to clarify network change #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed `index.html` from `main`. Now it's auto-generated from `index.bs` and put into `gh-pages` branch. Available at https://wicg.github.io/unload-beacon/ * Fixed broken super-linter badge. Related: WICG#22
network changes Specifically, beacons should not leak information that it should not know, which only happens when a page goes into bfcache Fix WICG#28
fergald
approved these changes
Sep 5, 2022
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| Authors: [Darren Willis](https://github.com/darrenw), [Fergal Daly](https://github.com/fergald), [Ming-Ying Chung](https://github.com/mingyc) - Google | |||
|
|
|||
| [](https://github.com/WICG/unload-beacon/actions/workflows/super-linter.yml) | |||
| [](https://github.com/WICG/unload-beacon/actions/workflows/super-linter.yml) | |||
There was a problem hiding this comment.
seems like it shouldn't be in this change.
There was a problem hiding this comment.
Sorry this is already commited to main branch. Not sure how to remove it from this PR but should be no-op on merging.
README.md
Outdated
| * Beacons are only sent over the same network that was active when the beacon was registered | ||
| (e.g. if the user goes offline and moves to a new network, discard pending beacons). | ||
| * Beacons must not leak information that a page should not know when it is in bfcache, | ||
| e.g. if network changes after a page goes into bfcache, the beacon should not be sent; if the page then goes out of bfcache, the beacon can be sent. |
There was a problem hiding this comment.
I could suggest
"if the page is then restored from bfcache"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Privacy section to clarify why beacon needs to be stopped when network changes (#27 #28)
Also added links to related privacy discussions: #3, #27, #30, #34
Updated beacon TTL to 30min per suggestion in #16 (comment)