Add spec for multi-seller getInterestGroupAdAuctionData #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@qingxinwu PTAL |
qingxinwu
reviewed
Jan 24, 2025
|
[sad] David Dabbs reacted to your message:
…________________________________
From: brusshamilton ***@***.***>
Sent: Thursday, January 23, 2025 9:49:42 PM
To: WICG/turtledove ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [WICG/turtledove] Add spec for multi-seller getInterestGroupAdAuctionData (PR #1389)
External to the Groupe / en provenance de l'extérieur du Groupe
@qingxinwu<https://github.com/qingxinwu> PTAL
—
Reply to this email directly, view it on GitHub<#1389 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AABK3LDH2AROHGVF5KV6F7D2MFPXNAVCNFSM6AAAAABVV7TDUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJRGA4DONJRHE>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
------------------------------------------------------------------------
Disclaimer The information in this email and any attachments may contain proprietary and confidential information that is intended for the addressee(s) only. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, retention or use of the contents of this information is prohibited. When addressed to our clients or vendors, any information contained in this e-mail or any attachments is subject to the terms and conditions in any governing contract. If you have received this e-mail in error, please immediately contact the sender and delete the e-mail.
|
qingxinwu
reviewed
Jan 27, 2025
qingxinwu
reviewed
Jan 28, 2025
qingxinwu
reviewed
Jan 28, 2025
spec.bs
Outdated
| 1. Set |requestContext|'s [=server auction request context/request ID=] field to |requestId|. | ||
| 1. Set |requestContext|'s [=server auction request context/request context=] field to |context|. | ||
| 1. [=map/Set=] |global|'s [=associated Document's=] [=node navigable's=] | ||
| [=traversable navigable's=] [=traversable navigable/saved Bidding and Auction request context=][|requestId|] to |requestContext|. |
There was a problem hiding this comment.
this does not seem right, which keeps overwriting the requestId's context to the next config's context. Do we need to use |requestId| + |seller| as the key now? https://crsrc.org/c/content/browser/interest_group/ad_auction_page_data.h;drc=12855e28398f2355e8002664108acc3c289401e0;l=150
There was a problem hiding this comment.
Done. I forgot about that change, good catch!
qingxinwu
approved these changes
Jan 31, 2025
| <dl dfn-for="auction data per seller result"> | ||
| : <dfn>seller</dfn> | ||
| :: The [=origin=] of the seller that this result corresponds to. Will match one of | ||
| the sellers in the [=auction data config=]. |
There was a problem hiding this comment.
[=auction data config=] only has one seller, and there is a list of [=auction data configs=]. Maybe "match one of the [=auction data configs=]' [=auction data config/seller=]?
| @@ -3188,7 +3188,7 @@ a [=list=] of [=interest groups=] |bidIgs|, and a [=reporting context map=] | |||
| 1. Let |requestId| be the value of |auctionConfig|'s [=auction config/server response id=]. | |||
| 1. Let |requestContexts| be the value of |global|'s [=associated Document's=] [=node navigable's=] | |||
| [=traversable navigable's=] [=traversable navigable/saved Bidding and Auction request context=]. | |||
| 1. If |requestContexts|[|requestId|] does not [=map/exist=], return null. | |||
| 1. If |requestContexts|[(|seller|,|requestId|)] does not [=map/exist=], return null. | |||
| 1. Let |requestContext| be |requestContexts|[|requestId|]. | |||
There was a problem hiding this comment.
Suggested change
| 1. Let |requestContext| be |requestContexts|[|requestId|]. | |
| 1. Let |requestContext| be |requestContexts|[（|seller|, |requestId|）]. |
qingxinwu
reviewed
Feb 2, 2025
| :: |requestSize| | ||
| : [=auction data config/per buyer config=] | ||
| :: |perBuyerConfigs| | ||
| 1. [=list/Append=] |config| to |configs|. |
There was a problem hiding this comment.
instead of this, probably slightly better to change [=auction data config=]'s seller and coordinator to a list of (seller, coordinator) (probably a new struct), so that it's clearer that all other fields are shared for all sellers. Won't let it block this PR though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff