Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Enable random seeding from the configuration universally. #142

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

RHammond2
Copy link
Contributor

This PR addresses #141 by bringing the configuration's random seeding variables up to the Simulation level, making it consistent with the Simulation.from_config() logic.

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 53.75%. Comparing base (9f8db22) to head (f1e251a).

Files Patch % Lines
wombat/core/simulation_api.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #142      +/-   ##
===========================================
- Coverage    53.84%   53.75%   -0.10%     
===========================================
  Files           22       21       -1     
  Lines         3742     3743       +1     
  Branches       770      772       +2     
===========================================
- Hits          2015     2012       -3     
- Misses        1605     1609       +4     
  Partials       122      122              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RHammond2 RHammond2 merged commit 72d717f into develop Mar 19, 2024
4 of 6 checks passed
@RHammond2 RHammond2 deleted the fix/random-seed-from-config branch March 19, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant