Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Operating Reductions Inconsistently Rest #143

Merged
merged 7 commits into from
Apr 5, 2024

Conversation

RHammond2
Copy link
Contributor

This PR directly resolves #140 and another underlying issue causing persistent processes to timeout after they have been recreated following a replacement event.

To achieve this, the following changes have been implemented:

  • original operating levels are tracked for 100% reduction failures
  • replacement flag for interruptions are passed so that failure processes can't persist after a replacement event

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 59.25926% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 53.62%. Comparing base (9f8db22) to head (094f5d7).
Report is 1 commits behind head on develop.

Files Patch % Lines
wombat/windfarm/system/cable.py 50.00% 6 Missing and 2 partials ⚠️
wombat/windfarm/system/subassembly.py 60.00% 3 Missing and 3 partials ⚠️
wombat/core/service_equipment.py 50.00% 5 Missing ⚠️
wombat/core/repair_management.py 72.72% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #143      +/-   ##
===========================================
- Coverage    53.84%   53.62%   -0.23%     
===========================================
  Files           22       22              
  Lines         3742     3765      +23     
  Branches       770      777       +7     
===========================================
+ Hits          2015     2019       +4     
- Misses        1605     1619      +14     
- Partials       122      127       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RHammond2 RHammond2 merged commit bd90ba4 into develop Apr 5, 2024
5 of 6 checks passed
@RHammond2 RHammond2 deleted the bug_fix/operational_reduction branch April 5, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant